Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Move all lib/domains tests to local single test runner #3784

Merged
merged 3 commits into from
Mar 5, 2016

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Mar 4, 2016

Part of #3822.

This is similar to #3773. It does exactly the same steps to speed up test execution.

This pull request seeks to eliminate subtree-specific Makefiles in the client/lib/domains directory, used always for testing, with a single test runner for the entirety of the client/lib/domains directory.

The changes eliminated 4 Makefiles.

Benefits include:

  • Improved performance by decreasing number of Mocha/Babel reinitializations
  • Fewer files to maintain

Testing instructions:

Ensure tests pass by running make test from the project root directory.

@gziolo gziolo self-assigned this Mar 4, 2016
@gziolo gziolo added Framework [Feature Group] Emails & Domains Features related to email integrations and domain management. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 4, 2016
@gziolo
Copy link
Member Author

gziolo commented Mar 4, 2016

/cc @aduth @gwwar @blowery @mtias

@gwwar
Copy link
Contributor

gwwar commented Mar 4, 2016

👍 Maybe add a quick usage note in client/lib/domains/README.md and :shipit:

@gwwar gwwar added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 4, 2016
@blowery
Copy link
Contributor

blowery commented Mar 4, 2016

Maybe we move this to lib and let things start opting in there instead? too big?

@blowery
Copy link
Contributor

blowery commented Mar 4, 2016

Nah, ship it. Can address later.

@gziolo gziolo force-pushed the update/single-test-runner-lib-domains branch from 3534e9a to 7881dee Compare March 5, 2016 08:21
@gziolo
Copy link
Member Author

gziolo commented Mar 5, 2016

@gwwar: Usage note added with 7881dee

@blowery: I'm still not sure how to tackle it at a global level. Definitely it's going to be easier to split all work needed if we start grouping tests in subfolder that aren't on the very top level. We can always move that level up :)

Thanks for a review!

gziolo added a commit that referenced this pull request Mar 5, 2016
…b-domains

Domains: Move all lib/domains tests to local single test runner
@gziolo gziolo merged commit b0e9641 into master Mar 5, 2016
@gziolo gziolo deleted the update/single-test-runner-lib-domains branch March 5, 2016 08:31
@gziolo gziolo mentioned this pull request Mar 7, 2016
19 tasks
@gziolo gziolo added this to the Framework: Single test runner milestone Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. Framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants