-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domains: Move all lib/domains tests to local single test runner #3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 Maybe add a quick usage note in |
Maybe we move this to |
Nah, ship it. Can address later. |
3534e9a
to
7881dee
Compare
gziolo
added a commit
that referenced
this pull request
Mar 5, 2016
…b-domains Domains: Move all lib/domains tests to local single test runner
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature Group] Emails & Domains
Features related to email integrations and domain management.
Framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3822.
This is similar to #3773. It does exactly the same steps to speed up test execution.
This pull request seeks to eliminate subtree-specific
Makefile
s in theclient/lib/domains
directory, used always for testing, with a single test runner for the entirety of theclient/lib/domains
directory.The changes eliminated 4
Makefiles
.Benefits include:
Testing instructions:
Ensure tests pass by running
make test
from the project root directory.