Test: Port lib/terms tests over to single runner #4053
Conversation
This one was pretty complicated because of module-level mock work. When you turn on Mockery, we clean out the module cache. That means if you need to test the interactions between an external singleton (say a Dispatcher) and the module under test, you need to re-require both the Dispatcher _and_ the module under test. This way, they both are working with the same instance of the singleton. If you don't re-require the Dispatcher, when you try to test dispatch through it, the module under test will never see the dispatch. This is because the instance that you're using in the test is different from the instance the module under test is listening to. I also removed all of the usage of the fake dom in these tests because it doesn't appear they're actually using them.
blowery
changed the title
blowery
added
[Status] Needs Review
| @@ -30,6 +31,7 @@ if ( program.grep ) { | |||
| mocha.suite.beforeAll( function() { | |||
| Chai.use( immutableChai ); | |||
| Chai.use( sinonChai ); | |||
| sinon.assert.expose( Chai.assert, { prefix: '' } ); | |||
There was a problem hiding this comment.
http://sinonjs.org/docs/#assert-expose - this is really nice feature! 👍
There was a problem hiding this comment.
My second thought is that sinon-chai (http://sinonjs.org/docs/#assertions) in most cases duplicates what sinon.assert.expose offers (https://github.com/domenic/sinon-chai/blob/master/lib/sinon-chai.js#L117) ...
We should figure out if it makes sense to keep both approaches or recommend in docs one of them :)
There was a problem hiding this comment.
Yeah, this was mostly a stopgap to avoid having to do too much surgery on existing tests. I'd started to move over to the expect syntax and then chickened out. 🐔
|
Great job! I added 2 commits with some minor changes. If you like them you can merge this PR. I'm giving thumbs up 👍 Let me know if you like the idea of moving non-test files to subfolders. As I understand we are going to use pattern matching for test files (sth like |
I think that's essential. Could you add it to the master move post I put up on the p2? |
|
Sure, doing it now. |
Test: Port lib/terms tests over to single runner
scruffian
removed
the
[Status] Needs Review
This one was pretty complicated because of module-level mock work.
When you turn on Mockery, we clean out the module cache. That means if you need to test
the interactions between an external singleton (say a Dispatcher) and the module under test,
you need to re-require both the Dispatcher and the module under test. This way, they
both are working with the same instance of the singleton.
If you don't re-require the Dispatcher, when you try to test dispatch through it, the module
under test will never see the dispatch. This is because the instance that you're using in the test
is different from the instance the module under test is listening to.
I also removed all of the usage of the fake dom in these tests because it doesn't appear they're actually using them.