Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Port CommentStore, FeedPostStore to the single runner #4354

Merged
merged 2 commits into from
Mar 30, 2016
Merged

Test: Port CommentStore, FeedPostStore to the single runner #4354

merged 2 commits into from
Mar 30, 2016

Conversation

blowery
Copy link
Contributor

@blowery blowery commented Mar 28, 2016

  • CommentStore
  • FeedPostStore

@blowery blowery force-pushed the test/more-stores branch 2 times, most recently from f67e3a6 to 1ee8c88 Compare March 28, 2016 18:49
@blowery blowery added this to the Framework: Single test runner milestone Mar 28, 2016
@blowery
Copy link
Contributor Author

blowery commented Mar 28, 2016

Part of #3942

@blowery blowery changed the title Test: Port some more stores over to the single runner Test: Port CommentStore, FeedPostStore to the single runner Mar 28, 2016
@blowery blowery added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Mar 28, 2016
@blowery
Copy link
Contributor Author

blowery commented Mar 28, 2016

To test:

Tests should pass

Load the Reader. Find a test post. Leave a comment. Refresh. Leave another.

@gziolo gziolo mentioned this pull request Mar 30, 2016
Closed
@gziolo gziolo added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 30, 2016
@gziolo
Copy link
Member

gziolo commented Mar 30, 2016

Looks great. Reader also works as expected :shipit:

@blowery blowery merged commit 063aa18 into master Mar 30, 2016
@blowery blowery deleted the test/more-stores branch March 30, 2016 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Framework
Projects
None yet
Milestone
Framework: Single test runner
Development

Successfully merging this pull request may close these issues.
4 participants
@blowery @gziolo @lancewillett @scruffian