-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signup: Single site signup layout bug #448
Conversation
…o use a function to output the button, to keep the code DRY
QA passed 👍 |
Code looks good 👍 |
Works, the only issue is: But after clicking skip it changes to "My Sites" |
@artpi: nice catch, though this is also not related to this change, we need to create follow up PRs. |
Signup: Single site signup layout bug
Reported in #471 |
Reported in #473 |
This is only a problem when the user has one site because if the user has more than one site, layoutFocus recognises that the focus will have changed and resets it (https://github.com/Automattic/wp-calypso/blob/8b9be6225433a058c07a4ae9b424cf29fe828a29/client/lib/layout-focus/index.js#L68). When the user has only one site the layoutFocus has never been set, so the router doesn't know to reset it. Another solution would be to just always reset the navigation to content on navigation, but I guess this will be annoying for mobile users who want to keep the sidebar open.
Fixes #442
Testing
git checkout fix/442-signup-layout
cc @designsimply