Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup: Single site signup layout bug #448

Merged
merged 4 commits into from
Nov 23, 2015
Merged

Conversation

scruffian
Copy link
Member

This is only a problem when the user has one site because if the user has more than one site, layoutFocus recognises that the focus will have changed and resets it (https://github.com/Automattic/wp-calypso/blob/8b9be6225433a058c07a4ae9b424cf29fe828a29/client/lib/layout-focus/index.js#L68). When the user has only one site the layoutFocus has never been set, so the router doesn't know to reset it. Another solution would be to just always reset the navigation to content on navigation, but I guess this will be annoying for mobile users who want to keep the sidebar open.

Fixes #442

Testing

  1. git checkout fix/442-signup-layout
  2. Open http://calypso.dev:3000/start in an incognito window
  3. Create a site
  4. Click on "My Site" (you need to only have one)
  5. Click on "Add New WordPress"
  6. Assert that the signup loads correctly.
  • Code review
  • QA review

cc @designsimply

@scruffian scruffian added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. labels Nov 22, 2015
@scruffian scruffian self-assigned this Nov 22, 2015
@gziolo
Copy link
Member

gziolo commented Nov 23, 2015

This is not related, but adding it here. I was trying to add site for the user that had blog marked as spam:

screen shot 2015-11-23 at 08 55 41

@gziolo
Copy link
Member

gziolo commented Nov 23, 2015

QA passed 👍

@gziolo
Copy link
Member

gziolo commented Nov 23, 2015

Code looks good 👍

@gziolo gziolo added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 23, 2015
@artpi
Copy link
Contributor

artpi commented Nov 23, 2015

Works, the only issue is:
after creating SECOND site, on the screen with "Customize / etc" - the one just after creation, the top bar stil is "My Site" instead of "my Sites"
https://cloudup.com/c49ibiD8d9Y

But after clicking skip it changes to "My Sites"

@gziolo
Copy link
Member

gziolo commented Nov 23, 2015

@artpi: nice catch, though this is also not related to this change, we need to create follow up PRs.

scruffian added a commit that referenced this pull request Nov 23, 2015
Signup: Single site signup layout bug
@scruffian scruffian merged commit 0f09972 into master Nov 23, 2015
@scruffian scruffian deleted the fix/442-signup-layout branch November 23, 2015 09:23
@scruffian
Copy link
Member Author

This is not related, but adding it here. I was trying to add site for the user that had blog marked as spam

Reported in #471

@scruffian
Copy link
Member Author

Works, the only issue is: after creating SECOND site, on the screen with "Customize / etc" - the one just after creation, the top bar stil is "My Site" instead of "my Sites"

Reported in #473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signup: 1st screen is mostly blank when trying to add a 2nd blog to an account with one blog
3 participants