-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Sites sidebar: Show items from admin-menu state #45631
Conversation
A bit of a hack, but makes things look nicer for the demo
Skipping review as this is the exact same set of changes that was previously reviewed and approved in #45531. |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Webpack Runtime (~99 bytes added 📈 [gzipped])
Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded. App Entrypoints (~57 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~2947 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~43816 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Note: These are the same changes that were in #45531, which were reverted due to failing smoke tests, which were related to end of day limits on account creation, not the PR changes.
Changes proposed in this Pull Request
nav-unification
)Testing instructions
See: #45435