Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Sites sidebar: Show items from admin-menu state #45631

Merged
merged 14 commits into from
Sep 14, 2020

Conversation

mreishus
Copy link
Contributor

Note: These are the same changes that were in #45531, which were reverted due to failing smoke tests, which were related to end of day limits on account creation, not the PR changes.

Changes proposed in this Pull Request

Testing instructions

See: #45435

@mreishus mreishus added the [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. label Sep 14, 2020
@mreishus mreishus requested a review from a team September 14, 2020 13:35
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 14, 2020
@mreishus
Copy link
Contributor Author

Skipping review as this is the exact same set of changes that was previously reviewed and approved in #45531.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Webpack Runtime (~99 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
manifest       +610 B  (+1.0%)      +99 B  (+0.7%)

Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded.

App Entrypoints (~57 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +439 B  (+0.0%)       +9 B  (+0.0%)
entry-login                 +118 B  (+0.0%)      +16 B  (+0.0%)
entry-gutenboarding         +118 B  (+0.0%)      +16 B  (+0.0%)
entry-domains-landing       +118 B  (+0.0%)      +16 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~2947 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
home                        +1005 B  (+0.2%)     +408 B  (+0.4%)
comments                     +936 B  (+0.2%)     +112 B  (+0.1%)
woocommerce                  +935 B  (+0.0%)      +86 B  (+0.0%)
stats                        +935 B  (+0.2%)     +118 B  (+0.1%)
posts-custom                 +935 B  (+0.3%)     +120 B  (+0.1%)
posts                        +935 B  (+0.3%)     +120 B  (+0.1%)
google-my-business           +935 B  (+0.3%)      +86 B  (+0.1%)
zoninator                    +914 B  (+0.3%)      +82 B  (+0.1%)
wp-super-cache               +914 B  (+0.4%)      +82 B  (+0.1%)
themes                       +914 B  (+0.3%)      +82 B  (+0.1%)
theme                        +914 B  (+0.4%)      +82 B  (+0.1%)
sites                        +914 B  (+1.1%)      +82 B  (+0.3%)
settings-writing             +914 B  (+0.2%)      +82 B  (+0.1%)
settings-security            +914 B  (+0.4%)      +82 B  (+0.1%)
settings-performance         +914 B  (+0.4%)      +82 B  (+0.1%)
settings-jetpack             +914 B  (+0.5%)      +82 B  (+0.2%)
settings-discussion          +914 B  (+0.5%)      +82 B  (+0.2%)
settings                     +914 B  (+0.2%)      +82 B  (+0.1%)
sensei                       +914 B  (+1.1%)      +82 B  (+0.3%)
scan                         +914 B  (+0.3%)      +82 B  (+0.1%)
purchases                    +914 B  (+0.1%)      +82 B  (+0.0%)
preview                      +914 B  (+0.6%)      +82 B  (+0.2%)
post-editor                  +914 B  (+0.0%)      +82 B  (+0.0%)
plugins                      +914 B  (+0.2%)      +82 B  (+0.1%)
pages                        +914 B  (+0.4%)     +126 B  (+0.2%)
migrate                      +914 B  (+0.7%)      +82 B  (+0.2%)
media                        +914 B  (+0.2%)      +82 B  (+0.1%)
marketing                    +914 B  (+0.2%)      +82 B  (+0.1%)
jetpack-connect              +914 B  (+0.1%)      +82 B  (+0.0%)
jetpack-cloud-settings       +914 B  (+0.6%)      +82 B  (+0.2%)
jetpack-cloud                +914 B  (+1.1%)      +82 B  (+0.3%)
import                       +914 B  (+0.4%)      +82 B  (+0.1%)
hosting                      +914 B  (+0.5%)      +82 B  (+0.1%)
hello-dolly                  +914 B  (+1.0%)      +82 B  (+0.3%)
gutenberg-editor             +914 B  (+0.1%)      +82 B  (+0.0%)
export                       +914 B  (+0.7%)      +82 B  (+0.2%)
email                        +914 B  (+0.4%)      +82 B  (+0.1%)
earn                         +914 B  (+0.3%)      +82 B  (+0.1%)
domains                      +914 B  (+0.1%)      +82 B  (+0.0%)
customize                    +914 B  (+0.8%)      +82 B  (+0.2%)
concierge                    +914 B  (+0.3%)      +82 B  (+0.1%)
checkout                     +914 B  (+0.1%)      +82 B  (+0.0%)
backup                       +914 B  (+0.2%)      +82 B  (+0.1%)
activity                     +914 B  (+0.2%)      +82 B  (+0.1%)
plans                        +836 B  (+0.2%)     -647 B  (-0.5%)
people                       +836 B  (+0.2%)     -595 B  (-0.6%)
reader                        +22 B  (+0.0%)      +61 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~43816 bytes added 📈 [gzipped])

name                                          parsed_size           gzip_size
async-load-my-sites-sidebar-unified-switcher    +154078 B    (new)   +42565 B    (new)
async-load-my-sites-sidebar                        +896 B  (+0.6%)     +134 B  (+0.3%)
async-load-blocks-inline-help-popover              +103 B  (+0.0%)    +1017 B  (+1.2%)
async-load-blocks-inline-help                      +100 B  (+0.1%)       +8 B  (+0.0%)
async-load-components-jetpack-sidebar               +44 B  (+0.2%)      +16 B  (+0.3%)
async-load-design-blocks                            +43 B  (+0.0%)      +15 B  (+0.0%)
async-load-components-web-preview-component         +22 B  (+0.0%)      +61 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mreishus
Copy link
Contributor Author

Teamcity and circleci test failures are expected for any changeset that touches the file containing the legacy reducers.

2020-09-14_08-47
2020-09-14_08-48

@mreishus mreishus merged commit a11165a into master Sep 14, 2020
@mreishus mreishus deleted the add/sidebar-unified-again branch September 14, 2020 13:52
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants