-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ectoplasm color scheme (Method B) #47075
Conversation
@@ -97,5 +98,13 @@ export default function ( translate ) { | |||
imageUrl: contrastImg, | |||
}, | |||
}, | |||
{ | |||
label: translate( 'Ectoplasm' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 139 times:
translate( 'Ectoplasm', { context: 'admin color scheme'} )
ES Score: 21
There seems to be an issue with the sidebar text flipping from white to black on hover+select in conjunction with the "secondary color" text. The alt text color doesn't support changing on hover, so the "premium" word is hard to read when "plans" is hovered or selected. https://github.com/Automattic/wp-calypso/blob/2cbd24e59ffd24df0797bd61bc6e383d29bd6b44/client/layout/sidebar/style.scss#L197-L212 - No simple &:hover color |
- From wp-admin
cfe48da
to
564a4e8
Compare
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~10 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~62 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~148 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
One part of #47036
Method B is defined in #47103. There's a "Method A" copy of the PR here: #47122.
Changes proposed in this Pull Request
Testing instructions
To see the wp-admin color scheme, create an atomic site, then visit /wp-admin/profile.php, choose color scheme and save.
Calypso:
WP-Admin:
Known Issues:
It doesn't flip in wp-admin: