Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ectoplasm color scheme (Method B) #47075

Closed
wants to merge 3 commits into from

Conversation

mreishus
Copy link
Contributor

@mreishus mreishus commented Nov 3, 2020

One part of #47036
Method B is defined in #47103. There's a "Method A" copy of the PR here: #47122.

Changes proposed in this Pull Request

  • Add ectoplasm color scheme

Testing instructions

  • Visit /me/account
  • Choose ectoplasm and save

To see the wp-admin color scheme, create an atomic site, then visit /wp-admin/profile.php, choose color scheme and save.

Calypso:
2020-11-03_16-12

WP-Admin:
2020-11-03_16-14

Known Issues:

  • As I'm limited to the colors on https://color-studio.blog/, I couldn't find a good match for the green. Purple is not perfect either but is closer.
  • In calypso, the masterbar is a darker purple than the sidebar to match the other calypso themes. In wp-admin, they're the same.
  • Calypso "wants" the main button color to be a -50 lightness, which is darker than the wp-admin one.
  • The wp-admin pallette shows an orange, but I couldn't find it used anywhere while using the site.
    2020-11-03_16-17
  • Hovering in the sidebar flips the text color from white to black for contrast reasons:
    2020-11-03_16-18
    It doesn't flip in wp-admin:
    2020-11-03_16-18_1
  • We would have to port these changes back to wp-admin. But how?

@mreishus mreishus self-assigned this Nov 3, 2020
@matticbot
Copy link
Contributor

@mreishus mreishus added the [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. label Nov 3, 2020
@@ -97,5 +98,13 @@ export default function ( translate ) {
imageUrl: contrastImg,
},
},
{
label: translate( 'Ectoplasm' ),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 139 times:
translate( 'Ectoplasm', { context: 'admin color scheme'} ) ES Score: 21

@mreishus
Copy link
Contributor Author

mreishus commented Nov 3, 2020

There seems to be an issue with the sidebar text flipping from white to black on hover+select in conjunction with the "secondary color" text. The alt text color doesn't support changing on hover, so the "premium" word is hard to read when "plans" is hovered or selected.

2020-11-03_16-40
2020-11-03_16-40_1

https://github.com/Automattic/wp-calypso/blob/2cbd24e59ffd24df0797bd61bc6e383d29bd6b44/client/layout/sidebar/style.scss#L197-L212 - No simple &:hover color

@mreishus mreishus force-pushed the add/color-scheme-ectoplasm branch from cfe48da to 564a4e8 Compare November 4, 2020 21:50
@mreishus mreishus changed the title Add ectoplasm color scheme Add ectoplasm color scheme (Method B) Nov 4, 2020
@mreishus mreishus marked this pull request as draft November 4, 2020 21:57
@matticbot
Copy link
Contributor

matticbot commented Nov 5, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~10 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main        +12 B  (+0.0%)      +10 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~62 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
account       +205 B  (+0.1%)      +62 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~148 bytes added 📈 [gzipped])

name                                           parsed_size           gzip_size
async-load-design-blocks                            +205 B  (+0.0%)      +59 B  (+0.0%)
async-load-design                                   +205 B  (+0.0%)      +67 B  (+0.0%)
async-load-lib-preferences-helper                    +12 B  (+0.1%)       +9 B  (+0.2%)
async-load-calypso-blocks-inline-help-popover        +12 B  (+0.0%)      +13 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mreishus
Copy link
Contributor Author

mreishus commented Nov 5, 2020

We'll be going with Option A: #47103 #47122

@mreishus mreishus closed this Nov 5, 2020
@mreishus mreishus deleted the add/color-scheme-ectoplasm branch December 14, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants