-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coffee color scheme from wp-admin #47173
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~47 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~87 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 This is coming together! Just a few minor things. Coffee could benefit from the same border treatment on the top bar as Ectoplasm:
I'm seeing the dark outline around the inline help button:
Noticed the gray plan flag in the sidebar could use a color shift:
And the Reader notification icon is still pink:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/calypso-color-schemes/src/shared/color-schemes/_coffee.scss
Outdated
Show resolved
Hide resolved
I believe I've addressed everything except the circle around the FAB Inline Help button (explanation is in the ectoplasm PR #47122) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing the changes @mreishus!
LGTM!
The override for the nudge banner is causing issues when the nav unification flag is on (top right, text "free domain available" unreadable): I could make the override to be more specific, but I'm worried about it causing more issues I haven't seen yet, or that it will get lost as we reorganize CSS as the nav unification project continues. I propose removing the override, sticking with the base neutral colors set, and waiting until we control the banner with theme variables instead of neutral colors. @sixhours @cpapazoglou |
One part of #47036
Changes proposed in this Pull Request
Testing instructions
To see the wp-admin color scheme, create an atomic site, then visit /wp-admin/profile.php, choose color scheme and save.
Calypso:
Wp-admin:
Notes
If you're following along with Ectoplasm from #47122, you'll see I generated a palette of "Ectoplasm green" in -10 to -90 values. For this one, I found that "Studio Orange" was a close enough match for primary+accent colors and reused it. Orange and brown are close to each other in terms of color hue, who would have thunk it? I'm open to revision or ideas on this, though.
In wp-admin this is a "low contrast" scheme, which means that certain buttons are black instead of the highlight color. I haven't accounted for that here.