Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coffee color scheme from wp-admin #47173

Merged
merged 16 commits into from
Nov 10, 2020
Merged

Add coffee color scheme from wp-admin #47173

merged 16 commits into from
Nov 10, 2020

Conversation

mreishus
Copy link
Contributor

@mreishus mreishus commented Nov 5, 2020

One part of #47036

Changes proposed in this Pull Request

  • Add coffee color scheme

Testing instructions

  • Visit /me/account
  • Choose coffee and save

To see the wp-admin color scheme, create an atomic site, then visit /wp-admin/profile.php, choose color scheme and save.

Calypso:
2020-11-05_17-14

Wp-admin:
2020-11-05_17-13

Notes

If you're following along with Ectoplasm from #47122, you'll see I generated a palette of "Ectoplasm green" in -10 to -90 values. For this one, I found that "Studio Orange" was a close enough match for primary+accent colors and reused it. Orange and brown are close to each other in terms of color hue, who would have thunk it? I'm open to revision or ideas on this, though.

In wp-admin this is a "low contrast" scheme, which means that certain buttons are black instead of the highlight color. I haven't accounted for that here.

@matticbot
Copy link
Contributor

@mreishus mreishus self-assigned this Nov 5, 2020
@mreishus mreishus added the [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. label Nov 5, 2020
@mreishus mreishus requested a review from sixhours November 5, 2020 23:19
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 5, 2020
@mreishus mreishus requested review from lcollette and a team November 5, 2020 23:19
@matticbot
Copy link
Contributor

matticbot commented Nov 5, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~47 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
account       +162 B  (+0.0%)      +47 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~87 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
async-load-design-blocks       +162 B  (+0.0%)      +43 B  (+0.0%)
async-load-design              +162 B  (+0.0%)      +44 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@sixhours sixhours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 This is coming together! Just a few minor things. Coffee could benefit from the same border treatment on the top bar as Ectoplasm:

Screen Shot 2020-11-06 at 10 24 21 AM

I'm seeing the dark outline around the inline help button:

Screen Shot 2020-11-06 at 10 06 04 AM

Noticed the gray plan flag in the sidebar could use a color shift:

Screen Shot 2020-11-06 at 10 05 52 AM

And the Reader notification icon is still pink:

Screen Shot 2020-11-06 at 10 14 26 AM

Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Sidebar Menu Headings should be white

@mreishus mreishus mentioned this pull request Nov 6, 2020
94 tasks
@mreishus
Copy link
Contributor Author

mreishus commented Nov 6, 2020

For the upsell nudge, I added a custom override. However, it's limited in scope to that one css class combination. It doesn't seem to be themeable as calypso hardcodes it to a neutral color:

2020-11-06_15-48_1

My override is a 15% darken of the base color:
2020-11-06_15-48

None of the other themes currently do this.

@mreishus
Copy link
Contributor Author

mreishus commented Nov 6, 2020

I believe I've addressed everything except the circle around the FAB Inline Help button (explanation is in the ectoplasm PR #47122)

Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing the changes @mreishus!

LGTM!

@mreishus
Copy link
Contributor Author

mreishus commented Nov 10, 2020

The override for the nudge banner is causing issues when the nav unification flag is on (top right, text "free domain available" unreadable):

With Override:
2020-11-10_09-56

Without Override:
2020-11-10_09-53

I could make the override to be more specific, but I'm worried about it causing more issues I haven't seen yet, or that it will get lost as we reorganize CSS as the nav unification project continues. I propose removing the override, sticking with the base neutral colors set, and waiting until we control the banner with theme variables instead of neutral colors. @sixhours @cpapazoglou

@mreishus mreishus merged commit ae3e5cf into master Nov 10, 2020
@mreishus mreishus deleted the add/color-scheme-coffee branch November 10, 2020 18:37
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants