Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focused Launch: Connect domain picker step with the launch store #47191

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

alshakero
Copy link
Member

@alshakero alshakero commented Nov 6, 2020

Changes proposed in this Pull Request

  • Connects the domain step to the launch store

Testing instructions - requires sandboxing

  1. In apps/editing-toolkit run yarn dev --sync.
  2. Sandbox testingfocusedflow.wordpress.com.
  3. Visit https://testingfocusedflow.wordpress.com/wp-admin/post-new.php.
  4. In console, type wp.data.dispatch('automattic/launch' ).openFocusedLaunch().
  5. Play with domain picker. You should be able to pick a paid and a free domain.

Partially fixes #46862

@alshakero alshakero requested a review from ciampo November 6, 2020 15:31
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 6, 2020
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~54 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding       +106 B  (+0.0%)      +54 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Async-loaded Components (~22 bytes added 📈 [gzipped])

name                                           parsed_size           gzip_size
async-load-calypso-blocks-editor-launch-modal       +191 B  (+0.1%)      +22 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@alshakero alshakero changed the title Focuses Launch: Connect domain picker step with the launch store Focused Launch: Connect domain picker step with the launch store Nov 6, 2020
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Just a note, that the way the domain is retrieved will change when #47233 gets implemented

@ciampo ciampo merged commit 5759e80 into master Nov 9, 2020
@ciampo ciampo deleted the update/domain-step-state branch November 9, 2020 17:00
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 9, 2020
@ciampo ciampo mentioned this pull request Nov 9, 2020
19 tasks
@alshakero alshakero restored the update/domain-step-state branch November 11, 2020 10:14
@alshakero alshakero deleted the update/domain-step-state branch November 11, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focused Launch: Domain step
3 participants