Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of Concept: Config Enable/Disable API #47535

Closed
wants to merge 1 commit into from

Conversation

mreishus
Copy link
Contributor

Proof of Concept: Config Enable/Disable API

Testing Instructions

  • Visit calypso with nav-unification turned on
  • Look at the bottom of the sidebar, click on the poorly decorated links to set the config variable on and off
    2020-11-17_17-59

@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~142 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +126 B  (+0.0%)      +47 B  (+0.0%)
entry-login                 +126 B  (+0.0%)      +30 B  (+0.0%)
entry-gutenboarding         +126 B  (+0.0%)      +31 B  (+0.0%)
entry-domains-landing       +126 B  (+0.0%)      +34 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Async-loaded Components (~131 bytes added 📈 [gzipped])

name                                         parsed_size           gzip_size
async-load-calypso-my-sites-sidebar-unified       +490 B  (+0.9%)     +131 B  (+0.9%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mreishus
Copy link
Contributor Author

Changes folded into #47527

@mreishus mreishus closed this Nov 18, 2020
@mreishus mreishus deleted the try/config-enable-disable-api branch November 11, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants