Update desktop to Electron v11

[nsakaimbo]

Description

Update to Electron v11 to support Apple Silicon.

This is ready-to-go but hold off on merging so we can stagger this into our next desktop release.

CI

• Mac
• Linux (Circle)
• Linux (TeamCity)

Manual Smoke Testing

• Mac
• Linux
• Windows

[matticbot]

Test live: https://calypso.live/?branch=desktop-electron-v11

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[wp-desktop]

WordPress Desktop CI Failure for job "wp-desktop-mac".

@nsakaimbo please inspect this job's build steps for breaking changes at this link. For temporal failures, you may try to "Rerun Workflow from Failed".

Please also ensure this branch is rebased off latest Calypso.

wp-desktop ci passing, closing review

[nsakaimbo]

Update:

CI is passing (save for TeamCity), and all platforms seem to be working as expected during manual smoke-testing.

TeamCity CI is failing with the error:

[22:23:39]v12.18.4 is already installed.
[22:23:40]_XSERVTransmkdir: ERROR: euid != 0,directory /tmp/.X11-unix will not be created.
[22:24:16]Error: Command failed: npx mocha /home/teamcity-3/buildAgent/work/c4a9d5b38c1dacde/desktop/e2e/tests/e2e.js --timeout 20000 --exit --reporter mocha-multi-reporters --reporter-options configFile=/home/teamcity-3/buildAgent/work/c4a9d5b38c1dacde/desktop/e2e/mocha-reporter.json
[22:24:16]    at checkExecSyncError (child_process.js:630:11)
[22:24:16]    at execSync (child_process.js:666:15)
[22:24:16]    at run (/home/teamcity-3/buildAgent/work/c4a9d5b38c1dacde/desktop/e2e/run.js:139:3) {
[22:24:16]  status: 2,
[22:24:16]  signal: null,
[22:24:16]  output: [ null, null, null ],
[22:24:16]  pid: 558,
[22:24:16]  stdout: null,
[22:24:16]  stderr: null
[22:24:16]}
[22:24:16]error Command failed with exit code 1.
[22:24:16]Process exited with code 1

Inspecting the Electron logs of the process indicates this error:

FATAL:platform_shared_memory_region_posix.cc(255)] This is frequently caused by incorrect permissions on /dev/shm

@scinos Any educated guesses here? There's a SO post on this topic - I might take a stab at the --disable-dev-shm-usage Chrome flag.

Some context for the changes in this PR so far:

After upgrading to Electron v11, both TeamCity and Circle were failing with the error:

Unknown input format: 'avfoundation'

This error was resolved after this change, however a new error appeared:

FATAL:platform_shared_memory_region_posix.cc(255)] This is frequently caused by incorrect permissions on /dev/shm (from the Electron logs in Circle)

Removing these additional Chrome arguments seemed to do the trick - Circle is now passing again, but TeamCity is not. 🤔

[scinos]

I'd try --disable-dev-shm-usage. When working on the migration, I saw it used somewhere in CircleCI docker images (I can't find it right now). It is also recommended by Google itself

[nsakaimbo]

I gave --disable-dev-shm-usage a try and the TC build still bombed, however with a more specific error message:

[452:1119/155121.617675:FATAL:setuid_sandbox_host.cc(158)] The SUID sandbox helper binary 
was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. 
You need to make sure that /home/teamcity-0/buildAgent/work/c4a9d5b38c1dacde/desktop/node_modules/electron/dist/chrome-sandbox 
is owned by root and has mode 4755.

There's an existing thread in the Electron repo about this issue, although I'm yet to understand what's going on exactly...

[scinos]

I think that is caused by the missing --disable-setuid-sandbox, I remember getting that error before.

Our CI image doesn't have sudo, so we can't easily change the permissions of those files. If having sandboxing working is the only option, we would need to rework the CI image.

[nsakaimbo]

Tried --disable-setuid-sandbox and still no dice, but did get the error message:

[452:1119/221402.136001:FATAL:zygote_host_impl_linux.cc(117)] No usable sandbox! 
Update your kernel or see https://chromium.googlesource.com/chromium/src/+/master/docs/linux/suid_sandbox_development.md 
for more information on developing with the SUID sandbox. 
If you want to live dangerously and need an immediate workaround, 
you can try using --no-sandbox.

Trying --no-sandbox now, but wondering if it will conflict with the sandbox: false security setting that we're enabling as part of this upgrade (link).

[nsakaimbo]

Update: Based on last CI run, adding --no-sandbox breaks Circle, and the TC build looks like it's attempting to run but fails with the error:

_XSERVTransmkdir: ERROR: euid != 0,directory /tmp/.X11-unix will not be created.

Some cursory web searching seems to indicate this is also a permissions-related error. Reverting e2e app arguments so at least the Circle build is working while we look into an alternate solution for the TC build.

[nsakaimbo]

Update: TeamCity build is working and these changes are now ready to land.

[mokagio]

Update: TeamCity build is working and these changes are now ready to land.

👍