Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav unification: update Aquatic color scheme to be compatible with nav unification #47583

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

frontdevde
Copy link
Contributor

Changes proposed in this Pull Request

  • update Aquatic color scheme to be compatible with nav unification

While working on porting Aquatic to wp-admin in Automattic/jetpack#17828, I noticed we will need a few more changes to the color scheme in Calypso to work with Nav Unification.

Before After
Screenshot 2020-11-19 at 13 37 50 Screenshot 2020-11-19 at 13 24 04

Testing instructions

  • Visit the Calypso live link below
  • Navigate to /me/account and select the color scheme
  • Add ?flags=nav-unification to the URL
  • Compare to ?flags=nav-unification in production

@frontdevde frontdevde added the [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. label Nov 19, 2020
@frontdevde frontdevde self-assigned this Nov 19, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 19, 2020
@frontdevde frontdevde merged commit 6efab7e into master Nov 19, 2020
@frontdevde frontdevde deleted the update/aquatic-nav-unification branch November 19, 2020 13:48
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants