Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav unification: update Nightfall color scheme to be compatible with Nav Unification #47751

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Nav unification: update Nightfall color scheme to be compatible with Nav Unification #47751

merged 1 commit into from
Nov 26, 2020

Conversation

frontdevde
Copy link
Contributor

Changes proposed in this Pull Request

  • update Nightfall color scheme to be compatible with Nav Unification

While working on porting Nightfall to wp-admin in Automattic/jetpack#17828, I noticed we will need a few more changes to the color scheme in Calypso to work with Nav Unification.

Before After
Screenshot 2020-11-25 at 16 52 07 Screenshot 2020-11-25 at 16 51 32

Testing instructions

  • Navigate to /me/account in production and select the color scheme
  • Check out this branch, run yarn && yarn start, visit http://calypso.localhost:3000/
  • Add your user to Treatment Variation in Experiment (see paYJgx-1af-p2) to enable nav unification
  • Compare against nav unification without this branch

@frontdevde frontdevde added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. labels Nov 25, 2020
@frontdevde frontdevde self-assigned this Nov 25, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/nightfall-nav-unification

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

cpapazoglou
cpapazoglou approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frontdevde! Works as expected!

@frontdevde frontdevde force-pushed the update/nightfall-nav-unification branch from f0a672d to b11f3e0 Compare November 26, 2020 06:52
@frontdevde frontdevde merged commit a3a76b4 into trunk Nov 26, 2020
@frontdevde frontdevde deleted the update/nightfall-nav-unification branch November 26, 2020 07:58
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 26, 2020
@frontdevde frontdevde mentioned this pull request Nov 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpapazoglou cpapazoglou cpapazoglou approved these changes

Assignees

@frontdevde frontdevde

Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frontdevde @matticbot @cpapazoglou