-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calypso editor: do not set Calypsoify on Jetpack 9.2 #47925
Conversation
Calypsoify is currently broken in Jetpack 9.2: Automattic/jetpack#17939 Until a point release is available, this may avoid creating Fatal errors on sites that do not have Calypsoify enabled yet.
b0cd9f6
to
d984d7c
Compare
d984d7c
to
4bdd229
Compare
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~79 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This pretty much works as we want, but I had Calypsoify activated and with this change, I was still getting the fatal error until I added We might need to add this version check to |
I'm not quite sure how to do that. I tried adding the parameter there earlier, but that didn't seem to be taken into account. :\ |
I did a quick test on a Jetpack site, and it worked well on a site that did not already have Calypsoify enabled. As expected, the fatal did occur if Calypsoify was already enabled on the site. |
Follow-up from #47925 Jetpack's Calypsoify broke in version 9.2, and was then fixed in 9.2.1. We consequently only need to exclude sites that run 9.2 (alpha, betas, and stable).
Changes proposed in this Pull Request
Calypsoify is currently broken in Jetpack 9.2:
Automattic/jetpack#17939
Until a point release is available, this may avoid creating Fatal errors on sites that do not have Calypsoify enabled yet.
Testing instructions