Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calypso editor: do not set Calypsoify on Jetpack 9.2 #47925

Merged
merged 4 commits into from
Dec 3, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 1, 2020

Changes proposed in this Pull Request

Calypsoify is currently broken in Jetpack 9.2:
Automattic/jetpack#17939

Until a point release is available, this may avoid creating Fatal errors on sites that do not have Calypsoify enabled yet.

Testing instructions

  • Start from a Jetpack site (not Atomic) connected to WordPress.com and running Jetpack 9.2.
  • Go to Jetpack > Settings and enable SSO
  • Go to WordPress.com > Posts for that site
  • Click on the button to start a new post.
  • You should be redirected to the wp-admin editor without any Calypsoify styling.
  • Now try the same thing with an Atomic site; the iFramed block editor should load instead of the redirection.

Calypsoify is currently broken in Jetpack 9.2:
Automattic/jetpack#17939

Until a point release is available, this may avoid creating Fatal errors on sites that do not have Calypsoify enabled yet.
@matticbot
Copy link
Contributor

@jeherve jeherve force-pushed the update/gutenberg-editor-no-calypsoify branch from b0cd9f6 to d984d7c Compare December 1, 2020 18:13
@jeherve jeherve force-pushed the update/gutenberg-editor-no-calypsoify branch from d984d7c to 4bdd229 Compare December 1, 2020 18:15
@matticbot
Copy link
Contributor

matticbot commented Dec 1, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~79 bytes added 📈 [gzipped])

name              parsed_size           gzip_size
gutenberg-editor       +212 B  (+0.0%)      +79 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jeherve jeherve added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Dec 1, 2020
@pablinos
Copy link
Contributor

pablinos commented Dec 1, 2020

This pretty much works as we want, but I had Calypsoify activated and with this change, I was still getting the fatal error until I added &calypsoify=0 to the URL.

We might need to add this version check to getGutenbergEditorUrl as well (or instead) and ensure that parameter is added to the URL when necessary.

@jeherve
Copy link
Member Author

jeherve commented Dec 2, 2020

We might need to add this version check to getGutenbergEditorUrl as well (or instead) and ensure that parameter is added to the URL when necessary.

I'm not quite sure how to do that. I tried adding the parameter there earlier, but that didn't seem to be taken into account. :\

@kbrown9
Copy link
Member

kbrown9 commented Dec 2, 2020

I did a quick test on a Jetpack site, and it worked well on a site that did not already have Calypsoify enabled.

As expected, the fatal did occur if Calypsoify was already enabled on the site.

@jeherve jeherve merged commit 19ee366 into trunk Dec 3, 2020
@jeherve jeherve deleted the update/gutenberg-editor-no-calypsoify branch December 3, 2020 11:20
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 3, 2020
jeherve added a commit that referenced this pull request Dec 16, 2020
Follow-up from #47925

Jetpack's Calypsoify broke in version 9.2, and was then fixed in 9.2.1.
We consequently only need to exclude sites that run 9.2 (alpha, betas, and stable).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants