-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try/e2e jest #52786
Closed
Closed
Try/e2e jest #52786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test live: https://calypso.live/?branch=try/e2e-jest |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
scinos
force-pushed
the
ci/e2e/cleanup-config
branch
from
May 13, 2021 03:53
af99dfa
to
7c0f10f
Compare
Implemented in #53702 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Migrate Calypso e2e tests to Jest.
This is not meant to be merged as is, but an exploration of what we would need to do a full migration and what would be the pros and cons.
Migration:
The migration itself is quite trivial. There are a few changes we have to make to our tests, but mostly can be done by search&replace:
this.timeout()
:jest.setTimeout()
in the setup files.before
/after
hooks should be renamed tobeforeAll
/afterAll
And that's pretty much it. The rest is split files with multiple
@parallel
suites, set up Jest and configure the build to use Jest instead of Magellan.Pros:
Seems to be a bit faster. I got a build in
3m:10s
, whiletrunk
is about3m:30s
. This doesn't even use Jest caching, so it may end up running in less than 3 minutes.jest-teamcity
reporter adds the test filename as part of the test name in TeamCity. This can help identify which tests is failing:Log are much easier to read, even when running multiple tests in parallel. It is easy to see what was the test suite, what step failed, the error and the stack trace:
Cons:
jest-teamcity
reporter adds the test filename as part of the test name... which means that renaming a file will erase the history of the test in TeamCity, as it will appear as a new test.