ci(e2e): Refactor Media helper to better handle concurrency #55678
Conversation
|
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-13430 |
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
scinos
force-pushed
the
chore/bump-fs-extra
branch
from
b14c839 to
9ea22cf
Compare
scinos
changed the title
matticbot
added
the
[Status] Needs Review
scinos
requested review from
WunderBart and
a team
and removed request for
worldomonation
| `( | ||
| `Confirm $block.blockName block is visible in published post`, | ||
| async ( { block, content } ) => { | ||
| // Pass the Block object class here then call the static method to validate. | ||
| await block.validatePublishedContent( page, content ); | ||
| } | ||
| ); | ||
|
|
||
| it( `Confirm Logso block is visible in published post`, async () => { |
There was a problem hiding this comment.
A side effect of the main change (move createTestImage inside a hook) is that we can't use logoImage to define a parameter anymore, as it doesn't exist when the test is defined.
There was a problem hiding this comment.
That's a bummer, but small price to pay for this change.
| @@ -78,39 +79,37 @@ export function createTestFile( { | |||
| const sourceFileDir = path.join( __dirname, '../../../../../test/e2e/image-uploads/' ); | |||
There was a problem hiding this comment.
This is outside the scope of this PR, but we should really refactor this out. A package shouldn't need to have knowledge of the directory structure of the project using said package. Instead, this path should come as part of sourceFileName
There was a problem hiding this comment.
With the EPERM issues resolved, another solution (that was originally intended) could be to have an image-source directory in this package which holds the test files.
How does that sound?
| } ); | ||
|
|
||
| it( `Confirm Audio block is visible in published post`, async () => { | ||
| await AudioBlock.validatePublishedContent( page ); |
There was a problem hiding this comment.
AudioBlock.validatePublishedContent() doesn't check for the content, it only looks for the presence of the <audio> tag. This was hidden by the previous implementation as block was type any, but now it is correctly detected by TypeScript.
scinos
force-pushed
the
chore/bump-fs-extra
branch
from
cd08e2f to
e19490b
Compare
github-actions
bot
removed
the
[Status] Needs Review
Changes proposed in this Pull Request
Refactor Media Helper for Playwright tests to handle concurrency better:
createTestFilewill use the temp directorycreateTestFileis now asyncAfter those changes, copying files was still breaking. Looks like removing
--security-opt seccomp=.teamcity/docker-seccomp.jsonfixed the problem. I believe we added it for Electron 11 (https://github.com/Automattic/wp-calypso/pull/47555/files) but it is not required here.Testing instructions
Verify e2e still pass