-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: use react-masonry-component
for StartCards
#5944
Conversation
Uses Masonry for layout in Cold Start. This renders the StartCards from left to right, rather then top to bottom via columns.
This is awesome Nate! 👏 Added a small update here: 949a989, just made margin around cards equal. |
Fixed a breakpoint issue in: df6faa4 @TooTallNate it seems like the gap between columns stays the same regardless of the size of the cards - even with the original width of Should be around |
@jancavan @TooTallNate can't we achieve this just with flexbox these days (with |
The cards don't appear in exact source order (e.g. the final card is on the bottom left for me), but should be close enough to vastly improve the loading experience for new cards 👍 |
@jancavan has experimented with Flexbox and Columns, and ultimately we've not found a solid solution (yet) that offers:
Horizontal flow seems to be the trickiest part. |
Looks good to me 🚢 |
Uses Masonry for layout in Cold Start (see https://github.com/eiriklv/react-masonry-component).
This renders the StartCards from left to right, rather then top to bottom via columns.
Example:
(Note that "TechnoScience as if People Mattered" is the 2nd entry in the DOM list, and is being rendered to the right of the first StartCard, as expected).
This is expected to make the interaction of loading more recs (#5652) be more pleasant.
/cc @jancavan @bluefuton
Test live: https://calypso.live/?branch=add/reacy-masonry-component