-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wordads instant: Family safe please #7272
Conversation
b5c8dc2
to
b7a2dfb
Compare
* Get WordAds Status of a site. | ||
* | ||
* @param {int} siteId The site ID | ||
* @returns {XMLHttpRequest} The XHR instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a promise object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Thank you, there was an issue in D2501-code. Fixed now. |
URL: { type: 'string' }, | ||
approved: { type: 'boolean' }, | ||
active: { type: 'boolean' }, | ||
unsafe: wordadsUnsafeValues, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be:
unsafe: { enum: wordadsUnsafeValues }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks!
👍 Verified that I can approve sites with the new patch. The Calypso PR should be good to go once the schema is fixed. |
Once patch is merged, I'll merge this |
Giving my 👍 on this too. |
Redux site stickers Add missing bracket after rebase Add tests to stickers reducer tree Fix notice Modify stickers to wordads status
060d2a4
to
db6f819
Compare
Fixes #723, goes with D2501-code
Visuals
Testing
Half-flow
Fulll flow
Test live: https://calypso.live/?branch=update/wordads-flagged
CC @rralian @dbspringer @lamosty @egill