Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused gutenboarding script #74539

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Remove unused gutenboarding script #74539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9fbf35
Remove unused gutenboarding script
noahtallen Mar 16, 2023
1231b45
Remove capture-site dep
noahtallen Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 0 additions & 48 deletions bin/install-gutenboarding-design-thumbnails-dependencies.js
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@
"@wordpress/stylelint-config": "^21.5.0",
"babel-loader": "^8.2.3",
"bunyan": "^1.8.15",
"capture-website": "^1.0.0",
"chalk": "^4.1.2",
"check-node-version": "^4.0.2",
"chroma-js": "^2.1.2",
Expand Down Expand Up @@ -273,7 +272,6 @@
"replace": "^1.1.5",
"sass": "^1.37.5",
"sass-loader": "^12.1.0",
"sharp": "^0.28",
"source-map": "^0.7.3",
"stackframe": "^1.1.1",
"stacktrace-gps": "^3.0.3",
Expand Down
25 changes: 2 additions & 23 deletions test/e2e/docs/troubleshooting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
<!-- TOC -->

- [Troubleshooting](#troubleshooting)
- [git pre-commit hook/husky](#git-pre-commit-hookhusky)
- [Package 'lcms2', required by 'vips', not found](#package-lcms2-required-by-vips-not-found)
- [git pre-commit hook/husky](#git-pre-commit-hookhusky)
- [Package 'lcms2', required by 'vips', not found](#package-lcms2-required-by-vips-not-found)

<!-- /TOC -->

Expand Down Expand Up @@ -40,24 +40,3 @@ yarn install
```

Once complete, running `git commit` should no longer trigger the git pre-commit hook error.

## Package 'lcms2', required by 'vips', not found
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be an issue any more :D


This issue is observed by Apple Silicon users when attempting to set up Calypso locally.

```
Package 'lcms2', required by 'vips', not found
gyp: Call to 'PKG_CONFIG_PATH="/usr/local/lib/pkgconfig:/usr/lib/pkgconfig" pkg-config --cflags-only-I vips-cpp vips glib-2.0 | sed s\/-I//g' returned exit status 0 while in binding.gyp. while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack at ChildProcess.onCpExit (/Users/keoshi/Documents/repos/wp-calypso/node_modules/node-gyp/lib/configure.js:353:16)
gyp ERR! stack at ChildProcess.emit (node:events:390:28)
gyp ERR! stack at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
gyp ERR! System Darwin 21.1.0
gyp ERR! command "/Users/keoshi/.nvm/versions/node/v16.11.1/bin/node" "/Users/keoshi/Documents/repos/wp-calypso/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/keoshi/Documents/repos/wp-calypso/node_modules/sharp
```

Solution:

Comment out the dependency for `sharp` in the [top-level `package.json`](https://github.com/Automattic/wp-calypso/blob/trunk/package.json#L276).
106 changes: 12 additions & 94 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9639,13 +9639,6 @@ __metadata:
languageName: node
linkType: hard

"agent-base@npm:5":
version: 5.1.1
resolution: "agent-base@npm:5.1.1"
checksum: 3baa3f01072c16e3955ce7802166e576cde9831af82b262aae1c780af49c0c84e82e64ba9ef9e7d1704fe29e9f0096a78a4f998ec137360fee3cb95186f97161
languageName: node
linkType: hard

"agent-base@npm:6, agent-base@npm:^6.0.2":
version: 6.0.2
resolution: "agent-base@npm:6.0.2"
Expand Down Expand Up @@ -12043,17 +12036,6 @@ __metadata:
languageName: node
linkType: hard

"capture-website@npm:^1.0.0":
version: 1.0.0
resolution: "capture-website@npm:1.0.0"
dependencies:
file-url: ^3.0.0
puppeteer: ^3.0.4
tough-cookie: ^4.0.0
checksum: feb0df563b3ae5801b7c5bcf2d46bba630dfa8674a8d31cec8ecc78bd264367084f85e75c50469e0199cebc8cb0701b83ebe6d8b6a8e0f9bb48758153da58b50
languageName: node
linkType: hard

"case-sensitive-paths-webpack-plugin@npm:^2.3.0":
version: 2.4.0
resolution: "case-sensitive-paths-webpack-plugin@npm:2.4.0"
Expand Down Expand Up @@ -12623,7 +12605,7 @@ __metadata:
languageName: node
linkType: hard

"color-convert@npm:^1.9.0, color-convert@npm:^1.9.1, color-convert@npm:^1.9.3":
"color-convert@npm:^1.9.0, color-convert@npm:^1.9.1":
version: 1.9.3
resolution: "color-convert@npm:1.9.3"
dependencies:
Expand Down Expand Up @@ -12655,7 +12637,7 @@ __metadata:
languageName: node
linkType: hard

"color-string@npm:^1.5.2, color-string@npm:^1.6.0":
"color-string@npm:^1.5.2":
version: 1.6.0
resolution: "color-string@npm:1.6.0"
dependencies:
Expand Down Expand Up @@ -12684,16 +12666,6 @@ __metadata:
languageName: node
linkType: hard

"color@npm:^3.1.3":
version: 3.2.1
resolution: "color@npm:3.2.1"
dependencies:
color-convert: ^1.9.3
color-string: ^1.6.0
checksum: 39345d55825884c32a88b95127d417a2c24681d8b57069413596d9fcbb721459ef9d9ec24ce3e65527b5373ce171b73e38dbcd9c830a52a6487e7f37bf00e83c
languageName: node
linkType: hard

"colord@npm:^2.7.0, colord@npm:^2.9.1, colord@npm:^2.9.2, colord@npm:^2.9.3":
version: 2.9.3
resolution: "colord@npm:2.9.3"
Expand Down Expand Up @@ -16637,7 +16609,7 @@ __metadata:
languageName: node
linkType: hard

"extract-zip@npm:2.0.1, extract-zip@npm:^2.0.0":
"extract-zip@npm:2.0.1":
version: 2.0.1
resolution: "extract-zip@npm:2.0.1"
dependencies:
Expand Down Expand Up @@ -16942,13 +16914,6 @@ __metadata:
languageName: node
linkType: hard

"file-url@npm:^3.0.0":
version: 3.0.0
resolution: "file-url@npm:3.0.0"
checksum: 31c5f85711bda47a471fd8d4a7217330102b74fb3b4dbd3626dd9cbe8c9afc1bf4584da2877abd84db392e3b4c2ad6d61ba4830b45a273dfbfd1172b443d8bb9
languageName: node
linkType: hard

"filelist@npm:^1.0.1":
version: 1.0.2
resolution: "filelist@npm:1.0.2"
Expand Down Expand Up @@ -19163,16 +19128,6 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"https-proxy-agent@npm:^4.0.0":
version: 4.0.0
resolution: "https-proxy-agent@npm:4.0.0"
dependencies:
agent-base: 5
debug: 4
checksum: fbba3e037ec04e1850e867064a763b86dd884baae9c5f4ad380504e321068c9e9b5de79cf2f3a28ede7c36036dce905b58d9f51703c5b3884d887114f4887f77
languageName: node
linkType: hard

"https-proxy-agent@npm:^5.0.0, https-proxy-agent@npm:^5.0.1":
version: 5.0.1
resolution: "https-proxy-agent@npm:5.0.1"
Expand Down Expand Up @@ -23098,7 +23053,7 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"mime@npm:^2.0.3, mime@npm:^2.3.1, mime@npm:^2.4.4, mime@npm:^2.4.6, mime@npm:^2.5.2":
"mime@npm:^2.3.1, mime@npm:^2.4.4, mime@npm:^2.4.6, mime@npm:^2.5.2":
version: 2.6.0
resolution: "mime@npm:2.6.0"
bin:
Expand Down Expand Up @@ -23765,7 +23720,7 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"node-addon-api@npm:^3.1.0, node-addon-api@npm:^3.2.0":
"node-addon-api@npm:^3.1.0":
version: 3.2.1
resolution: "node-addon-api@npm:3.2.1"
dependencies:
Expand Down Expand Up @@ -26063,7 +26018,7 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"prebuild-install@npm:^6.0.0, prebuild-install@npm:^6.1.2":
"prebuild-install@npm:^6.0.0":
version: 6.1.3
resolution: "prebuild-install@npm:6.1.3"
dependencies:
Expand Down Expand Up @@ -26237,7 +26192,7 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"progress@npm:2.0.3, progress@npm:^2.0.0, progress@npm:^2.0.1, progress@npm:^2.0.3":
"progress@npm:2.0.3, progress@npm:^2.0.0, progress@npm:^2.0.3":
version: 2.0.3
resolution: "progress@npm:2.0.3"
checksum: 1697e07cb1068055dbe9fe858d242368ff5d2073639e652b75a7eb1f2a1a8d4afd404d719de23c7b48481a6aa0040686310e2dac2f53d776daa2176d3f96369c
Expand Down Expand Up @@ -26390,7 +26345,7 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"proxy-from-env@npm:1.1.0, proxy-from-env@npm:^1.0.0, proxy-from-env@npm:^1.1.0":
"proxy-from-env@npm:1.1.0, proxy-from-env@npm:^1.1.0":
version: 1.1.0
resolution: "proxy-from-env@npm:1.1.0"
checksum: fe7dd8b1bdbbbea18d1459107729c3e4a2243ca870d26d34c2c1bcd3e4425b7bcc5112362df2d93cc7fb9746f6142b5e272fd1cc5c86ddf8580175186f6ad42b
Expand Down Expand Up @@ -26513,24 +26468,6 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"puppeteer@npm:^3.0.4":
version: 3.1.0
resolution: "puppeteer@npm:3.1.0"
dependencies:
debug: ^4.1.0
extract-zip: ^2.0.0
https-proxy-agent: ^4.0.0
mime: ^2.0.3
progress: ^2.0.1
proxy-from-env: ^1.0.0
rimraf: ^3.0.2
tar-fs: ^2.0.0
unbzip2-stream: ^1.3.3
ws: ^7.2.3
checksum: 906c7bdf5407e8635fe69d86f6d45c776d328454fb7dee5690c813bdf248502670437c657f8a8438656974afbcf921d62f307338f3ddfebbe20771295ae81ddd
languageName: node
linkType: hard

"qr.js@npm:0.0.0":
version: 0.0.0
resolution: "qr.js@npm:0.0.0"
Expand Down Expand Up @@ -29587,23 +29524,6 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"sharp@npm:^0.28":
version: 0.28.3
resolution: "sharp@npm:0.28.3"
dependencies:
color: ^3.1.3
detect-libc: ^1.0.3
node-addon-api: ^3.2.0
node-gyp: latest
prebuild-install: ^6.1.2
semver: ^7.3.5
simple-get: ^3.1.0
tar-fs: ^2.1.1
tunnel-agent: ^0.6.0
checksum: 7016319b0a6ecc4392ea345dfd470badddae2b106a4b1caed66d9766c4a7819d395c627eeb93cb7bcf761d9071def6593415f8ebec365efc2b582d6b366abbc0
languageName: node
linkType: hard

"shebang-command@npm:^1.2.0":
version: 1.2.0
resolution: "shebang-command@npm:1.2.0"
Expand Down Expand Up @@ -29679,7 +29599,7 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"simple-get@npm:^3.0.3, simple-get@npm:^3.1.0":
"simple-get@npm:^3.0.3":
version: 3.1.0
resolution: "simple-get@npm:3.1.0"
dependencies:
Expand Down Expand Up @@ -31068,7 +30988,7 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"tar-fs@npm:2.1.1, tar-fs@npm:^2.0.0, tar-fs@npm:^2.1.1":
"tar-fs@npm:2.1.1, tar-fs@npm:^2.0.0":
version: 2.1.1
resolution: "tar-fs@npm:2.1.1"
dependencies:
Expand Down Expand Up @@ -32110,7 +32030,7 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"unbzip2-stream@npm:1.4.3, unbzip2-stream@npm:^1.3.3":
"unbzip2-stream@npm:1.4.3":
version: 1.4.3
resolution: "unbzip2-stream@npm:1.4.3"
dependencies:
Expand Down Expand Up @@ -33747,7 +33667,6 @@ fsevents@^1.2.7:
bunyan: ^1.8.15
calypso: "workspace:^"
calypso-codemods: "workspace:^"
capture-website: ^1.0.0
chalk: ^4.1.2
check-node-version: ^4.0.2
chroma-js: ^2.1.2
Expand Down Expand Up @@ -33811,7 +33730,6 @@ fsevents@^1.2.7:
request: ^2.88.2
sass: ^1.37.5
sass-loader: ^12.1.0
sharp: ^0.28
source-map: ^0.7.3
stackframe: ^1.1.1
stacktrace-gps: ^3.0.3
Expand Down Expand Up @@ -34051,7 +33969,7 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"ws@npm:^7.2.3, ws@npm:^7.3.1, ws@npm:^7.4.5":
"ws@npm:^7.3.1, ws@npm:^7.4.5":
version: 7.5.9
resolution: "ws@npm:7.5.9"
peerDependencies:
Expand Down