Delete Site: toLowerCase() before validating domain #7458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebinnion
added
[Feature] Site Settings
ebinnion
force-pushed
the
update/delete-site-to-lower
branch
3 times, most recently
from
1d0258b to
c7f3b05
Compare
ebinnion
added
[Status] Needs Review
| @@ -195,7 +198,12 @@ export const DeleteSite = React.createClass( { | |||
| } | |||
| } ) | |||
| }</p> | |||
| <input className="delete-site__confirm-input" type="text" valueLink={ this.linkState( 'confirmDomain' ) }/> | |||
| <input | |||
There was a problem hiding this comment.
I'd personally indent the input and its attributes one more tab (although the misformatting was not introduced in this PR).
|
That's a nice catch! Also, PR looks and works fine for me 👍 I've commented inline with a very minor nitpick. Other than that, I think it is good to go |
tyxla
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
ebinnion
force-pushed
the
update/delete-site-to-lower
branch
from
c7f3b05 to
ffe5eae
Compare
ebinnion
force-pushed
the
update/delete-site-to-lower
branch
from
ffe5eae to
33a2822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At WordCamp Boston, a user came up to me while I was working the Jetpack booth and asked me to walk her through the process of deleting her site. So, I did that. But, as I walked the user through how to delete her site on her iPad, I realized that we weren't being very friendly to mobile users in our validation logic.
Specifically, our logic checks that the domain the user entered is exactly the same as the site's acutal domain. The problem with this is that the mobile keyboard by default capitalizes the first character. So, the user, after having entered her site domain multiple times became frustrated.
This PR aims to fix this by lower casing the entered domain before running validation logic as well as turning off
autoCapitalize.To test:
update/delete-site-to-lowerbranch/settings/general/$sitewhere$siteis a WP.com siteTest live: https://calypso.live/?branch=update/delete-site-to-lower