Buttons: Remove transparent border for Firefox #8581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… same as other browsers
matticbot
added
the
[Status] Needs Review
mtias
added
[Status] Needs Design Review
lancewillett
added
[Status] Ready to Merge
and removed
[Status] Needs Design Review
This was referenced Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was reported in #8567.
We have transparent border for buttons in Firefox that increase its height. And that's causing a misalignment when a button and a link sit next each other.
Before:
I'm not sure why we have it but, by removing the border, the height of button becomes as intended and we can fix the misalignment.
After:
Other buttons look good and more look the same as on other browsers like Chrome.