Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing: Fix untranslated display of Post-Types #8598

Merged
merged 1 commit into from
Oct 10, 2016

Conversation

akirk
Copy link
Member

@akirk akirk commented Oct 7, 2016

The sharing buttons retrieve the post-types not with the locale appended, thus they are displayed in English:

screenshot-wordpress com_2016-10-07_14-17-07

screen shot 2016-10-07 at 19 45 29

This adds the locale to the API call.

@akirk akirk added [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. i18n labels Oct 7, 2016
@matticbot
Copy link
Contributor

@akirk akirk changed the title Sharing: Post-Types are displayed untranslated Sharing: Fix untranslated display of Post-Types Oct 7, 2016
@akirk akirk force-pushed the fix/post-type-untranslated branch from bb3bb4d to 3bb552f Compare October 7, 2016 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants