-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: Sites Dashboard - Update Dataviews version to latest #89739
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~27 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~14230 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~41 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
342d283
to
d7870c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, nice work getting that filter dropdown to look as good as it does!
I found a couple of things when reviewing so will drop these here:
It looks like the border around the 'Add filter' button has a missing top border (when highlighted). Same with the Reset link after that has been pressed. It only shows briefly when testing locally - the effect is more visible testing on Horizon from what I can see.
Also, if I click on 'Needs Attention' from the sidebar, it opens up the filter dropdown (it does correctly select the right filter). That seems a bit of an odd experience, probably makes sense to hide that if we can? Maybe for a follow-up?
Another question I have is related to the dataviews related styles. Do we want to keep them all in one place, rather than across files? I would think so, purely because we're trying to decouple Jetpack / A4A styles from Dataviews generally. Most of these style additions look like they'd need to be linked with general Dataviews styles. This PR is relevant anyway - https://github.com/Automattic/wp-calypso/pull/89757/files - @cleacos do you know if it's better to merge one PR before the other and then sort out styles later? For example the decoupling PR first, then styles here can be moved into the new relevant files?
I noticed the same issues that Karen's commented. The top border issue also happens in the pagination option:
I'd say this PR needs some refinements or fixes before merging. We already have customers testing A4A, so we cannot proceed with these issues. That said, @coder-karen, your PR will go first, which means that after merging it, we will update any affected style in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Karen comments:
- We have to fix those UX issues and the style ones.
I added some designers as reviewers in case we need some feedback about it or alternatives.
@coder-karen, we have to update this comment too: https://github.com/Automattic/wp-calypso/pull/87979/files updating the lock version |
client/a8c-for-agencies/sections/sites/features/jetpack/jetpack-sites-dataviews.tsx
Show resolved
Hide resolved
client/a8c-for-agencies/sections/sites/features/jetpack/jetpack-sites-dataviews.tsx
Show resolved
Hide resolved
This should be ready for review again now. The remaining issue (dropdown display when clicking on 'Needs Attention' from the sidebar) has been added to an issue here: https://github.com/Automattic/automattic-for-agencies-dev/issues/351 |
I'm reviewing this again |
I was waiting for the Dotcom team to finish their work before their CfT. On Monday, I'll check everything with the recent updates and I'll ping them for a review too. |
b62247b
to
211919d
Compare
I was hoping to get another commit in WordPress/gutenberg#61307 but had some delays getting it merged, I think I'll just have to update the package version again once this is merged. |
For now, this is on hold until we decide what to do. I'm finishing the P2-post to talk about it. For Dotcom, the DataViews v1.1 breaks it a bit, more than A4A. |
Discussion about the DataViews future on: pe7F0s-1OO-p2 |
New reference: https://github.com/Automattic/jetpack-manage/issues/337 |
Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/311
Proposed Changes
Testing Instructions
yarn install
to make sure everything is set-up properly.yarn start-a8c-for-agencies
Changes:
Filter selection
Previous Version:
Latest:
When Preview Pane is open, filters now show multiple lines
Previews Version:
Latest:
Known Issue - Please ignore this one for now
When the Preview Pane is open and pagination is visible, the page's alignment looks off.
Pre-merge Checklist