Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert update webpack packages #91443

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Revert update webpack packages #91443

merged 1 commit into from
Jun 4, 2024

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Jun 4, 2024

Proposed Changes

Partially reverts #91367 because it was breaking the command-palette-wp-admin app (unsure if it was breaking other apps too).

Why are these changes being made?

To fix the command-palette-wp-admin app

Testing Instructions

  • In your sandbox run install-plugin.sh command-palette-wp-admin trunk
  • Sandbox widgets.wp.com and a simple site
  • Go to /wp-admin on your sandboxed site
  • Open the command palette (⌘ + K)
  • Observe the JS error: build.min.js?ver=20240604:6 Uncaught TypeError: Cannot read properties of undefined (reading 'jsx')
  • Apply now changes from this PR: install-plugin.sh command-palette-wp-admin revert/webpack-packages-updates
  • Reload /wp-admin and open the command palette
  • Make sure it works as expected without any JS error

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mmtr mmtr self-assigned this Jun 4, 2024
@mmtr mmtr added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 4, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • command-palette-wp-admin
  • editing-toolkit
  • o2-blocks
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug revert/webpack-packages-updates on your sandbox.

@mmtr mmtr requested review from tyxla and a team June 4, 2024 08:52
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thanks @mmtr!

Happy to investigate what's the cause if you don't have it on your plate already.

@mmtr
Copy link
Member Author

mmtr commented Jun 4, 2024

Failing E2E tests seem unrelated (see p1717487713672789-slack-C02DQP0FP)

Happy to investigate what's the cause if you don't have it on your plate already.

It'd be great if you could follow up on this. Thanks @tyxla!

@mmtr mmtr merged commit 5edecb4 into trunk Jun 4, 2024
15 of 17 checks passed
@mmtr mmtr deleted the revert/webpack-packages-updates branch June 4, 2024 08:59
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 4, 2024
tyxla added a commit that referenced this pull request Jun 4, 2024
@tyxla
Copy link
Member

tyxla commented Jun 4, 2024

Investigating and will submit a fix in #91454.

I've reverted to the supposedly broken state, but I can't reproduce. I'm following your (inverted) steps from above with the reverted branch, but can't reproduce it. Could you try with #91454 and let me know what I might be missing?

Command I'm testing with:

install-plugin.sh command-palette-wp-admin revert-91443-revert/webpack-packages-updates

@tyxla
Copy link
Member

tyxla commented Jun 4, 2024

I managed to reproduce it and will work on a fix, stay tuned.

@tyxla
Copy link
Member

tyxla commented Jun 4, 2024

Seems like it will have to wait until 6.6 is released, see WordPress/gutenberg#62202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants