-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: Extract strings from external @wordpress/* dependencies #92755
i18n: Extract strings from external @wordpress/* dependencies #92755
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* i18n: Extract strings from external @wordpress/* dependencies * Use wp-babel-makepot CLI to scan all @wordpress/* packages
* i18n: Extract strings from external @wordpress/* dependencies * Use wp-babel-makepot CLI to scan all @wordpress/* packages
Related to:
Proposed Changes
@wordpress/*
packages innode_modules
and merge them withcalypso-strings.pot
.Ideally, we'd be using the tree shaking data to filter out the strings that are not used in Calypso (see the initial implementation), but it's only available after building the app, which is not the case for the Translate job in TeamCity.
Why are these changes being made?
@wordpress/*
packages use translatable strings, but thenode_modules
directory is completely ignored from scanning.node_modules/@wordpress/*
directories and ensure the strings can be translated from within Calypso.Testing Instructions
Pre-merge Checklist