Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Extract strings from external @wordpress/* dependencies #92755

Merged

Conversation

yuliyan
Copy link
Member

@yuliyan yuliyan commented Jul 17, 2024

Related to:

  • 848-gh-Automattic/i18n-issues
  • 827-gh-Automattic/i18n-issues
  • 821-gh-Automattic/i18n-issues

Proposed Changes

  • Extract translatable strings from @wordpress/* packages in node_modules and merge them with calypso-strings.pot.

Ideally, we'd be using the tree shaking data to filter out the strings that are not used in Calypso (see the initial implementation), but it's only available after building the app, which is not the case for the Translate job in TeamCity.

Why are these changes being made?

  • Some of the @wordpress/* packages use translatable strings, but the node_modules directory is completely ignored from scanning.
  • With the changes introduced in this PR, we introduce an additional scanning for translatable strings that will look into the node_modules/@wordpress/* directories and ensure the strings can be translated from within Calypso.

Testing Instructions

  • Code review.
  • Inspect the artifacts from the Translate job in TeamCity.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/i18n-extract-strings-from-external-wordpress-dependencies on your sandbox.

@yuliyan yuliyan requested a review from a team July 22, 2024 10:32
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 22, 2024
@yuliyan yuliyan marked this pull request as ready for review July 22, 2024 10:46
Copy link
Contributor

@d-alleyne d-alleyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the strings are added to the calypso-strings.pot, specifically "No results", from Automattic/i18n-issues#848

CleanShot 2024-07-22 at 09 33 17

@yuliyan yuliyan merged commit 0f280ca into trunk Jul 22, 2024
15 of 16 checks passed
@yuliyan yuliyan deleted the update/i18n-extract-strings-from-external-wordpress-dependencies branch July 22, 2024 13:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 22, 2024
yuliyan added a commit that referenced this pull request Jul 22, 2024
gabrielcaires pushed a commit that referenced this pull request Jul 22, 2024
* i18n: Extract strings from external @wordpress/* dependencies

* Use wp-babel-makepot CLI to scan all @wordpress/* packages
gabrielcaires pushed a commit that referenced this pull request Jul 22, 2024
* i18n: Extract strings from external @wordpress/* dependencies

* Use wp-babel-makepot CLI to scan all @wordpress/* packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants