Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Fix header alignment with the DataViews table #94590

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

tiagonoronha
Copy link
Contributor

Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/1081

Proposed Changes

  • Fixes the header alignment across different breakpoints.
Before After
Screenshot 2024-09-16 at 19 10 19 Screenshot 2024-09-16 at 19 09 47

Testing Instructions

  • Open the live link
  • Go to the Sites list
  • Confirm that the header now aligns with the rest of the UI elements.
  • Resize the browser (or use developer tools) to check other breakpoints.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@tiagonoronha tiagonoronha requested a review from a team September 16, 2024 18:14
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 16, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@andrii-lysenko andrii-lysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it's definitely now aligned within Sites tab, but the header jumps when navigating between tabs. Eg from Overview to Sites.

I'm not quite sure on how better handle this. @jeffgolenski maybe you have a idea?

@tiagonoronha
Copy link
Contributor Author

@andrii-lysenko Thanks for the feedback. I noticed the issue was actually with the padding on the table and not the header.

If you test again it should basically behave the same as the Referrals view.

Copy link
Contributor

@andrii-lysenko andrii-lysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing that! LGTM!

@tiagonoronha tiagonoronha merged commit 38b40f4 into trunk Sep 20, 2024
10 checks passed
@tiagonoronha tiagonoronha deleted the a4a/fix/site-title-padding branch September 20, 2024 18:14
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants