-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: Fix header alignment with the DataViews table #94590
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it's definitely now aligned within Sites tab, but the header jumps when navigating between tabs. Eg from Overview to Sites.
I'm not quite sure on how better handle this. @jeffgolenski maybe you have a idea?
@andrii-lysenko Thanks for the feedback. I noticed the issue was actually with the padding on the table and not the header. If you test again it should basically behave the same as the Referrals view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing that! LGTM!
Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/1081
Proposed Changes
Testing Instructions
Pre-merge Checklist