Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hosting dashboard: Enable sorting for Plan and Status #94646

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Hosting dashboard: Enable sorting for Plan and Status #94646

merged 6 commits into from
Sep 20, 2024

Conversation

allilevine
Copy link
Member

@allilevine allilevine commented Sep 17, 2024 •
edited
Loading

Fixes https://github.com/Automattic/dotcom-forge/issues/9150

Proposed Changes

  • Add sorting for Plan and Status.
Screen.Recording.2024-09-19.at.4.39.56.PM.mov

No go: I'm not adding Plan filtering in this PR.

Why are these changes being made?

  • Users expect to be able to sort by every data column. Also, every column is sortable by default in DataViews. See: pdtkmj-2VB-p2#comment-5647

Testing Instructions

  • Open /sites
  • Verify that you can sort ascending and descending by Plan
  • Verify that you can sort ascending and descending by Status
  • Regression test that sorting by other columns (site, last published) still works correctly, and filtering by Status still works correctly.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Sep 17, 2024 •
edited
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-120129
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-120129&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-120129&env=a8c-for-agencies

@matticbot
Copy link
Contributor

matticbot commented Sep 17, 2024 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~983 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-login                +3090 B  (+0.2%)     +881 B  (+0.2%)
entry-domains-landing      +3019 B  (+0.4%)     +851 B  (+0.4%)
entry-browsehappy          +3019 B  (+1.5%)     +851 B  (+1.4%)
entry-subscriptions        +2949 B  (+0.2%)     +374 B  (+0.1%)
entry-stepper              +2615 B  (+0.1%)    +1204 B  (+0.2%)
entry-main                 +2478 B  (+0.1%)    +1123 B  (+0.2%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~41166 bytes added 📈 [gzipped])

name                                parsed_size           gzip_size
link-in-bio-tld-flow                    +3147 B  (+0.2%)     +684 B  (+0.1%)
update-design-flow                      +2817 B  (+0.2%)     +830 B  (+0.2%)
signup                                  +2304 B  (+0.8%)     +161 B  (+0.2%)
switch-site                             +1196 B  (+0.7%)     +299 B  (+0.6%)
themes                                  +1104 B  (+0.1%)    +2457 B  (+0.8%)
import-hosted-site-flow                  +998 B  (+0.1%)      -41 B  (-0.0%)
hosting                                  +981 B  (+0.1%)    +1164 B  (+0.2%)
stats                                    +968 B  (+0.1%)     -430 B  (-0.1%)
marketing                                +936 B  (+0.1%)    +3087 B  (+1.6%)
settings-security                        +887 B  (+0.2%)     -785 B  (-0.5%)
jetpack-social                           +880 B  (+0.1%)    +1938 B  (+1.0%)
earn                                     +845 B  (+0.1%)    +2057 B  (+0.9%)
scan                                     +824 B  (+0.1%)    +1314 B  (+0.6%)
staging-site                             +817 B  (+0.1%)     +136 B  (+0.0%)
videopress-flow                          +802 B  (+0.1%)     +854 B  (+0.3%)
people                                   +788 B  (+0.1%)     +911 B  (+0.5%)
theme                                    +776 B  (+0.1%)    +1179 B  (+0.5%)
home                                     +757 B  (+0.0%)     +200 B  (+0.0%)
promote-post-i2                          +756 B  (+0.2%)     +204 B  (+0.2%)
subscribers                              +721 B  (+0.1%)     +834 B  (+0.4%)
jetpack-cloud-overview                   +702 B  (+0.2%)     +106 B  (+0.1%)
checkout                                 +701 B  (+0.0%)     +817 B  (+0.2%)
activity                                 +690 B  (+0.1%)     +470 B  (+0.2%)
domains                                  +686 B  (+0.0%)     -323 B  (-0.1%)
sites-dashboard                          +683 B  (+0.1%)     +218 B  (+0.1%)
site-performance                         +683 B  (+0.0%)     +241 B  (+0.1%)
site-monitoring                          +683 B  (+0.0%)     +228 B  (+0.1%)
site-logs                                +683 B  (+0.0%)     +228 B  (+0.1%)
hosting-features                         +683 B  (+0.1%)     +216 B  (+0.1%)
plans                                    +678 B  (+0.0%)     +770 B  (+0.2%)
settings                                 +671 B  (+0.1%)     -277 B  (-0.1%)
github-deployments                       +657 B  (+0.0%)     +227 B  (+0.1%)
plugins                                  +638 B  (+0.0%)     +255 B  (+0.0%)
hundred-year-plan                        +636 B  (+1.8%)      +70 B  (+0.7%)
jetpack-cloud                            +618 B  (+0.2%)     +441 B  (+0.4%)
settings-podcast                         +612 B  (+0.1%)     +711 B  (+0.5%)
settings-jetpack                         +589 B  (+0.1%)     -304 B  (-0.2%)
jetpack-cloud-agency-sites-v2            +586 B  (+0.0%)    +1201 B  (+0.2%)
onboarding-flow                          +571 B  (+7.5%)      +87 B  (+4.0%)
write-flow                               +551 B  (+0.1%)     -491 B  (-0.2%)
build-flow                               +551 B  (+0.1%)     -410 B  (-0.2%)
comments                                 +548 B  (+0.1%)     +622 B  (+0.3%)
gutenberg-editor                         +546 B  (+0.1%)     +116 B  (+0.1%)
marketplace                              +528 B  (+0.1%)    +1150 B  (+0.4%)
pages                                    +526 B  (+0.1%)     +606 B  (+0.4%)
jetpack-cloud-settings                   +525 B  (+0.1%)     -261 B  (-0.2%)
copy-site-flow                           +525 B  (+0.1%)     +931 B  (+0.5%)
settings-reading                         +515 B  (+0.1%)     +674 B  (+0.5%)
settings-newsletter                      +515 B  (+0.1%)     +634 B  (+0.4%)
jetpack-search                           +515 B  (+0.1%)     +124 B  (+0.1%)
concierge                                +500 B  (+0.1%)     -278 B  (-0.2%)
a8c-for-agencies-sites                   +493 B  (+0.0%)     +654 B  (+0.1%)
backup                                   +490 B  (+0.0%)     -150 B  (-0.0%)
posts-custom                             +488 B  (+0.1%)    -1112 B  (-0.5%)
jetpack-connect                          +487 B  (+0.0%)     -316 B  (-0.1%)
import                                   +486 B  (+0.1%)     +816 B  (+0.4%)
woocommerce                              +483 B  (+0.2%)     -205 B  (-0.2%)
media                                    +463 B  (+0.0%)     -331 B  (-0.1%)
jetpack-cloud-plugin-management          +403 B  (+0.0%)     -672 B  (-0.1%)
email                                    +398 B  (+0.1%)    -1835 B  (-0.9%)
customize                                +397 B  (+0.1%)     -201 B  (-0.2%)
settings-discussion                      +396 B  (+0.1%)    +1080 B  (+0.9%)
notification-settings                    +369 B  (+0.0%)     +327 B  (+0.1%)
settings-performance                     +361 B  (+0.1%)     +881 B  (+0.6%)
woocommerce-installation                 +354 B  (+0.1%)      -67 B  (-0.1%)
settings-writing                         +354 B  (+0.1%)     -607 B  (-0.4%)
reblogging-flow                          +354 B  (+6.2%)      +96 B  (+5.2%)
design-first-flow                        +353 B  (+1.1%)      +50 B  (+0.6%)
privacy                                  +334 B  (+0.0%)     +569 B  (+0.3%)
developer                                +334 B  (+0.0%)     +522 B  (+0.2%)
reader                                   +327 B  (+0.0%)     +329 B  (+0.1%)
account                                  +320 B  (+0.0%)      +69 B  (+0.0%)
preview                                  +319 B  (+0.1%)     -216 B  (-0.2%)
migrate                                  +319 B  (+0.1%)     -218 B  (-0.2%)
jetpack-cloud-pricing                    +319 B  (+0.0%)     -161 B  (-0.1%)
jetpack-cloud-features-comparison        +319 B  (+0.0%)     -271 B  (-0.1%)
export                                   +319 B  (+0.1%)     -161 B  (-0.2%)
add-ons                                  +319 B  (+0.1%)     -205 B  (-0.2%)
purchases                                +309 B  (+0.0%)    -1749 B  (-0.3%)
devdocs                                  -287 B  (-0.2%)      -70 B  (-0.1%)
posts                                    +268 B  (+0.0%)     -641 B  (-0.3%)
google-my-business                       +267 B  (+0.1%)     +130 B  (+0.1%)
newsletter-flow                          +246 B  (+0.9%)      +31 B  (+0.4%)
link-in-bio-flow                         +246 B  (+1.4%)      +39 B  (+0.8%)
a8c-for-agencies-partner-directory       +241 B  (+0.1%)     +229 B  (+0.2%)
a8c-for-agencies-purchases               +238 B  (+0.0%)    +2075 B  (+1.1%)
a8c-for-agencies-marketplace             +231 B  (+0.0%)     +992 B  (+0.4%)
site-purchases                           +215 B  (+0.0%)    -1311 B  (-0.3%)
domain-user-transfer-flow                +209 B  (+0.1%)     +995 B  (+2.0%)
videopress-tv-flow                       +208 B  (+0.3%)      +29 B  (+0.1%)
with-theme-assembler-flow                +161 B  (+0.2%)      +81 B  (+0.7%)
update-options-flow                      +161 B  (+0.3%)      +80 B  (+1.3%)
trial-wooexpress-flow                    +161 B  (+0.3%)      +77 B  (+1.0%)
tailored-ecommerce-flow                  +161 B  (+0.3%)      +70 B  (+1.0%)
site-setup-wg                            +161 B  (+0.2%)      +89 B  (+0.5%)
site-setup-flow                          +161 B  (+0.2%)      +89 B  (+0.5%)
site-migration-flow                      +161 B  (+0.3%)      +83 B  (+0.9%)
readymade-template-flow                  +161 B  (+0.1%)      +81 B  (+0.3%)
migration-signup                         +161 B  (+0.3%)      +81 B  (+1.0%)
migration-flow                           +161 B  (+0.2%)      +82 B  (+0.6%)
import-flow                              +161 B  (+0.3%)      +97 B  (+1.0%)
hosted-site-migration-flow               +161 B  (+0.3%)      +82 B  (+0.8%)
free-post-setup-flow                     +161 B  (+0.3%)      +81 B  (+1.4%)
free-flow                                +161 B  (+0.2%)      +81 B  (+0.7%)
entrepreneur-flow                        +161 B  (+0.1%)      +75 B  (+0.2%)
assembler-first-flow                     +161 B  (+0.2%)      +84 B  (+0.6%)
ai-assembler-flow                        +161 B  (+0.2%)      +82 B  (+0.6%)
a8c-for-agencies-team                    +151 B  (+0.0%)     +345 B  (+0.1%)
a8c-for-agencies-referrals               +151 B  (+0.0%)     +384 B  (+0.1%)
jetpack-cloud-partner-portal             +145 B  (+0.0%)     -702 B  (-0.2%)
start-writing-flow                       +142 B  (+0.5%)      +30 B  (+0.3%)
a8c-for-agencies-settings                +138 B  (+0.1%)     +298 B  (+0.5%)
a8c-for-agencies-migrations              +138 B  (+0.1%)     +245 B  (+0.4%)
site-profiler                            +128 B  (+0.0%)     +779 B  (+0.9%)
performance-profiler                     +128 B  (+0.0%)     +779 B  (+0.7%)
help                                     -121 B  (-0.0%)      +33 B  (+0.0%)
account-close                            -119 B  (-0.0%)     +184 B  (+0.1%)
google-transfer                          +108 B  (+2.8%)      +63 B  (+4.6%)
domain-transfer                          +108 B  (+3.0%)      +63 B  (+4.8%)
transferring-hosted-site-flow            +103 B  (+0.1%)      +15 B  (+0.1%)
patterns                                 +103 B  (+0.0%)      +12 B  (+0.0%)
a8c-for-agencies-landing                  -68 B  (-0.1%)     +242 B  (+0.8%)
a8c-for-agencies-client                   +61 B  (+0.0%)     +311 B  (+0.1%)
security                                  +57 B  (+0.0%)     +152 B  (+0.1%)
a8c-for-agencies-overview                 +48 B  (+0.0%)     +366 B  (+0.1%)
sensei-flow                               +39 B  (+0.0%)     +612 B  (+0.3%)
new-hosted-site-flow-user-included        +36 B  (+0.6%)      +13 B  (+0.6%)
new-hosted-site-flow                      +36 B  (+0.6%)      +11 B  (+0.5%)
jetpack-app                               +36 B  (+0.0%)     +174 B  (+0.1%)
connect-domain                            +36 B  (+0.1%)      +10 B  (+0.1%)
a8c-for-agencies-plugins                  +35 B  (+0.0%)     +345 B  (+0.7%)
site-blocks                               -29 B  (-0.0%)     +148 B  (+0.1%)
me                                        +23 B  (+0.0%)     +121 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~24134 bytes removed 📉 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-calypso-layout-command-palette                                             +1196 B  (+0.6%)     +299 B  (+0.5%)
async-load-signup-steps-site-picker                                                    +407 B  (+0.3%)     +142 B  (+0.3%)
async-load-signup-steps-difm-site-picker                                               +407 B  (+0.3%)     +142 B  (+0.3%)
async-load-calypso-components-sites-popover                                            +407 B  (+0.3%)     +107 B  (+0.3%)
async-load-signup-steps-domains                                                        +365 B  (+0.1%)    +1726 B  (+1.0%)
async-load-design-blocks                                                               +332 B  (+0.0%)    -1033 B  (-0.2%)
async-load-calypso-post-editor-editor-media-modal                                      +262 B  (+0.0%)     +398 B  (+0.1%)
async-load-calypso-my-sites-checkout-modal                                             +209 B  (+0.0%)     +714 B  (+0.2%)
async-load-calypso-blocks-editor-checkout-modal                                        +209 B  (+0.0%)     +721 B  (+0.2%)
async-load-automattic-help-center                                                      +206 B  (+0.0%)      +38 B  (+0.0%)
async-load-purchase-modal-wrapper                                                      +196 B  (+0.1%)     +721 B  (+0.6%)
async-load-design-playground                                                           -172 B  (-0.0%)     -735 B  (-0.2%)
async-load-signup-steps-theme-selection                                                -157 B  (-0.0%)     -117 B  (-0.1%)
async-load-calypso-reader-sidebar                                                      +134 B  (+0.1%)      +20 B  (+0.1%)
async-load-calypso-my-sites-stats-summary                                              +134 B  (+0.3%)      +22 B  (+0.1%)
async-load-calypso-my-sites-current-site-notice                                        +134 B  (+0.2%)      +23 B  (+0.1%)
async-load-calypso-components-web-preview-component                                    +134 B  (+0.0%)     -177 B  (-0.1%)
async-load-calypso-blocks-jitm-templates-sidebar-banner                                +134 B  (+0.3%)      +21 B  (+0.1%)
async-load-calypso-blocks-jitm-templates-notice                                        +134 B  (+0.3%)      +23 B  (+0.1%)
async-load-calypso-blocks-jitm-templates-default                                       +134 B  (+0.3%)      +23 B  (+0.1%)
async-load-calypso-post-editor-media-modal                                             +128 B  (+0.0%)     +373 B  (+0.1%)
async-load-calypso-components-jetpack-portal-nav                                       +128 B  (+0.3%)     +731 B  (+5.6%)
async-load-calypso-jetpack-cloud-sections-sidebar-navigation-manage-selected-...       +122 B  (+0.1%)      +33 B  (+0.1%)
async-load-signup-steps-design-picker                                                  +108 B  (+0.2%)      +51 B  (+0.3%)
async-load-store-app-store-stats-listview                                              +105 B  (+0.0%)     +379 B  (+0.3%)
async-load-signup-steps-site-options                                                   +103 B  (+0.2%)      +27 B  (+0.2%)
async-load-signup-steps-site                                                           +103 B  (+0.2%)      +30 B  (+0.2%)
async-load-signup-steps-p2-site                                                        +103 B  (+0.2%)      +30 B  (+0.2%)
async-load-signup-steps-p2-confirm-email                                               +103 B  (+0.4%)      +31 B  (+0.4%)
async-load-signup-steps-clone-destination                                              +103 B  (+0.3%)      +30 B  (+0.3%)
async-load-masterbar-launchpad-navigator                                               +103 B  (+0.2%)      +15 B  (+0.1%)
async-load-calypso-blocks-jitm-templates-modal                                         +103 B  (+0.6%)      +34 B  (+0.6%)
async-load-automattic-whats-new                                                        +103 B  (+0.5%)      +15 B  (+0.2%)
async-load-design                                                                       +72 B  (+0.0%)     -437 B  (-0.1%)
async-load-calypso-layout-masterbar-checkout-tsx                                        +71 B  (+0.1%)      +65 B  (+0.2%)
async-load-calypso-layout-masterbar-checkout                                            +71 B  (+0.1%)     +154 B  (+0.6%)
async-load-store-app-store-stats                                                        +53 B  (+0.0%)     +487 B  (+0.3%)
async-load-calypso-blocks-app-banner                                                    +47 B  (+0.0%)      +80 B  (+0.2%)
async-load-signup-steps-rewind-form-creds                                               +36 B  (+0.1%)      +10 B  (+0.0%)
async-load-signup-steps-plans-theme-preselected                                         +36 B  (+0.0%)     +153 B  (+0.1%)
async-load-signup-steps-plans                                                           +36 B  (+0.0%)     +153 B  (+0.1%)
async-load-signup-steps-clone-credentials                                               +36 B  (+0.0%)      +21 B  (+0.1%)
async-load-signup-steps-woocommerce-install-confirm                                     +35 B  (+0.1%)      +28 B  (+0.2%)
async-load-signup-steps-page-picker                                                     +26 B  (+0.0%)     +146 B  (+0.1%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        +26 B  (+0.0%)     +150 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@allilevine allilevine self-assigned this Sep 19, 2024
@allilevine allilevine force-pushed the add/sorting-for-plan-and-status branch from fe84abd to a190a85 Compare September 19, 2024 19:31
@matticbot
Copy link
Contributor

matticbot commented Sep 19, 2024 •
edited
Loading

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/sorting-for-plan-and-status on your sandbox.

@allilevine allilevine changed the title Enable sorting for Plan and Status. Hosting dashboard: Enable sorting for Plan and Status Sep 19, 2024
@allilevine allilevine marked this pull request as ready for review September 19, 2024 20:42
@allilevine allilevine requested a review from a team September 19, 2024 20:42
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 19, 2024
cleacos
cleacos reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@cleacos cleacos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my side, the code looks good and it doesn't affect A4A.

@allilevine allilevine force-pushed the add/sorting-for-plan-and-status branch from bdb190e to 6663557 Compare September 20, 2024 13:12
@allilevine
Copy link
Member Author

On my side, the code looks good and it doesn't affect A4A.

Thank you for checking!

@allilevine allilevine force-pushed the add/sorting-for-plan-and-status branch from 8747f64 to fabbc80 Compare September 20, 2024 15:06
DustyReagan
DustyReagan approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests well!

@allilevine allilevine merged commit 3a76c46 into trunk Sep 20, 2024
12 checks passed
@allilevine allilevine deleted the add/sorting-for-plan-and-status branch September 20, 2024 20:21
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleacos cleacos cleacos left review comments

@DustyReagan DustyReagan DustyReagan approved these changes

@fushar fushar Awaiting requested review from fushar

@youknowriad youknowriad Awaiting requested review from youknowriad

@Addison-Stavlo Addison-Stavlo Awaiting requested review from Addison-Stavlo

Assignees

@allilevine allilevine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@allilevine @matticbot @DustyReagan @cleacos @Addison-Stavlo