-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spacing issues on the 2FA page #94737
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @moon0326, it seems that spacing between Continue with a backup code
button and Don’t have an account? Sign up
is 34px, but it should be 40px?
My bad! I used photoshop to measure pixels 🥲 Updated it in Adjust footer actions padding. It should report 40px from element to element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested well! 👍
2fda7b6
to
1972dc3
Compare
This PR fixes spacing issues on the 2FA login page.
Proposed Changes
Current:
Update:
Testing Instructions
config/development.json
and enablewoocommerce/core-profiler-passwordless-auth
feature flag.yarn start
Continue
Pre-merge Checklist