Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing issues on the 2FA page #94737

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Conversation

moon0326
Copy link
Contributor

@moon0326 moon0326 commented Sep 19, 2024

This PR fixes spacing issues on the 2FA login page.

Proposed Changes

Current:

Screenshot 2024-09-19 at 2 10 27 PM

Update:
Screenshot 2024-09-19 at 3 42 02 PM

Testing Instructions

  1. Setup woocommerce-start-dev-env with this branch.
  2. Go to your local wp-calypso and open config/development.json and enable woocommerce/core-profiler-passwordless-auth feature flag.
  3. Run yarn start
  4. Open an incognito window and navigbate to https://wordpress.com/log-in/jetpack?redirect_to=jetpack%2Fconnect%2Fauthorize%3Fclient_id%3D236381464%26redirect_uri%3D%26from%3Dwoocommerce-core-profiler&from=woocommerce-core-profiler
  5. Enter a passwordless email and click on Continue
  6. Check your email box for a magic login link
  7. Open the link in an incognito window.
  8. Confirm the changes.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/2fa-style-update on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@moon0326 moon0326 requested review from a team, psealock and chihsuan September 19, 2024 23:06
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 19, 2024
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @moon0326, it seems that spacing between Continue with a backup code button and Don’t have an account? Sign up is 34px, but it should be 40px?

Screenshot 2024-09-20 at 09 08 47

@moon0326
Copy link
Contributor Author

moon0326 commented Sep 20, 2024

Thanks @moon0326, it seems that spacing between Continue with a backup code button and Don’t have an account? Sign up is 34px, but it should be 40px?

Screenshot 2024-09-20 at 09 08 47

My bad! I used photoshop to measure pixels 🥲 Updated it in Adjust footer actions padding. It should report 40px from element to element.

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants