Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites: Fix Jetpack logo misalignment in the DataViews Properties list #94772

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

allilevine
Copy link
Member

@allilevine allilevine commented Sep 20, 2024

Fixes #94761

Proposed Changes

  • Add a span class for the Stats label that includes the Jetpack logo.
  • Remove the previous style rule that didn't apply to all instances of the label.
Before After
Screen Shot 2024-09-20 at 10 36 03 AM Screen Shot 2024-09-20 at 10 29 29 AM

Why are these changes being made?

  • To fix a bug resulting from updating the DataViews package to 14.3.0.

Testing Instructions

  • Go to /sites
  • Click the gear icon.
  • Verify that the Jetpack icon is aligned with "Stats".
  • Regression test that the Jetpack icon is aligned in the table header.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@allilevine allilevine self-assigned this Sep 20, 2024
@allilevine allilevine changed the title Sites: Fix JP logo misalignment in the DataViews Properties list Sites: Fix Jetpack logo misalignment in the DataViews Properties list Sep 20, 2024
@matticbot
Copy link
Contributor

matticbot commented Sep 20, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~10 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
staging-site              +43 B  (+0.0%)      +10 B  (+0.0%)
sites-dashboard           +43 B  (+0.0%)      +10 B  (+0.0%)
site-performance          +43 B  (+0.0%)      +10 B  (+0.0%)
site-monitoring           +43 B  (+0.0%)      +10 B  (+0.0%)
site-logs                 +43 B  (+0.0%)      +10 B  (+0.0%)
hosting-features          +43 B  (+0.0%)      +10 B  (+0.0%)
hosting                   +43 B  (+0.0%)      +10 B  (+0.0%)
github-deployments        +43 B  (+0.0%)      +10 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Sep 20, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/jp-logo-is-misaligned on your sandbox.

@@ -116,13 +116,6 @@
text-transform: uppercase;
}

svg {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reverting #89954 with this change.

I don't see any changes to the A4A favorite header with this branch applied, but cc'ing @cleacos just in case.
Screen Shot 2024-09-20 at 10 52 32 AM

@allilevine allilevine marked this pull request as ready for review September 20, 2024 14:53
@allilevine allilevine requested a review from a team September 20, 2024 14:53
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 20, 2024
Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I noticed a slight change in the spacing of the icon in the table header, but it still looks good to me.

Screenshot 2024-09-20 at 1 05 29 PM

@allilevine
Copy link
Member Author

I noticed a slight change in the spacing of the icon in the table header, but it still looks good to me.

Thanks! I made the spacing / gap wider to match the icon in the Plan column:
Screen Shot 2024-09-20 at 2 20 39 PM

@allilevine allilevine merged commit e3468f8 into trunk Sep 20, 2024
11 checks passed
@allilevine allilevine deleted the fix/jp-logo-is-misaligned branch September 20, 2024 18:42
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sites - In table options, JP logo is misaligned
3 participants