Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites: Move react elements to headers instead of labels #94785

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

allilevine
Copy link
Member

@allilevine allilevine commented Sep 20, 2024

Related to #94762

Proposed Changes

  • Move the column headers, which are React elements, to header instead of label, to fix tooltip issues and type errors in DataViews.
Before After
Screen Shot 2024-09-20 at 3 20 18 PM Screen Shot 2024-09-20 at 3 19 50 PM

Why are these changes being made?

  • Align with core and fix the tooltips.

Testing Instructions

  • Go to /sites
  • Verify that the column headers haven't changed from production.
  • Verify that if you click the gear icon and hover over the headers in the Properties list, the tooltip for the hide icon doesn't say [object Object].

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@allilevine allilevine self-assigned this Sep 20, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~24 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
staging-site             +104 B  (+0.0%)      +24 B  (+0.0%)
sites-dashboard          +104 B  (+0.0%)      +24 B  (+0.0%)
site-performance         +104 B  (+0.0%)      +24 B  (+0.0%)
site-monitoring          +104 B  (+0.0%)      +24 B  (+0.0%)
site-logs                +104 B  (+0.0%)      +24 B  (+0.0%)
hosting-features         +104 B  (+0.0%)      +24 B  (+0.0%)
hosting                  +104 B  (+0.0%)      +24 B  (+0.0%)
github-deployments       +104 B  (+0.0%)      +24 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants