Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Ability to download backups for expired Atomic sites #94796

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

villanovachile
Copy link
Collaborator

@villanovachile villanovachile commented Sep 21, 2024

Related to pIFnH-7g8-p2

Proposed Changes

  • Currently there is not a way for users to download backups (if they exist) from their expired Atomic site. This PR will introduce a card on the /backup/{siteSlug}/ page for simple sites that have been reverted and have a valid backup, that will allow users to download the latest valid backup.

Why are these changes being made?

  • When sites are reverted, a lossless import will trigger, however, all plugins, custom themes, theme customizations, custom post types (such as Woo products), and files stored outside of the media library are all lost, as they are not supported on simple plans. This change allows users to download a backup from the Jetpack > Backup page, so as long as it exists.

Testing Instructions

  • Visit /backup/{siteSlug}/ on a simple site that has never been Atomic - only the upgrade card should appear
  • Visit /backup/{siteSlug}/ on a simple site that was Atomic and has been reverted, and has a valid backup - the download flow should appear under the upgrade card, and should display the date of the backup.
  • Test downloading the backup flow

To-do

  • Make styling changes requested here: pIFnH-7g8-p2#comment-27853
  • Add collapsible section if confirmed that this should be added to Jetpack sites as well: pIFnH-7g8-p2#comment-27855
  • The wording for email notifications has been commented out, as currently this functionality is not supported on simple sites, as they face rewind authorization issues. We'll need to look into how feasible this is.
  • We'll need to split up the existing download.tsx component and abstract the header/body content to make it dynamic, while keeping the download functionality itself separate, ensuring that we can remove download-expired-plan.tsx, as it duplicates functionality.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@villanovachile villanovachile changed the title Add/add download backup to expired atomic sites Add: Ability to download backups for expired Atomic sites Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants