Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Add duplicator-pro and remove wpcom-migration from plugin compatibility #94797

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

villanovachile
Copy link
Collaborator

Related to Automattic/jetpack#39466

Proposed Changes

  • wpcom-migration was removed from, and duplicator-pro was added to thewpcomsh incompatible plugins. This PR will prevent the installation from dotcom marketplace.

Why are these changes being made?

  • To allow the installation of wpcom-migration, which will be required for the upcoming WordPress.com migration plugin
  • To prevent the installation of duplicator-pro. Although this pro version likely cannot installed via marketplace, we'll want to make sure there is parity between wpcomsh and calypso.

Testing Instructions

Before

image

After

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@villanovachile villanovachile self-assigned this Sep 21, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 21, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants