-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add upsell to Advanced Tools tab #96609
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~87 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~8167 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
client/sites/components/site-preview-pane/dotcom-preview-pane.tsx
Outdated
Show resolved
Hide resolved
client/sites/components/site-preview-pane/dotcom-preview-pane.tsx
Outdated
Show resolved
Hide resolved
4ae4e46
to
6c57e7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, thanks 👍
Found a small issue, we can follow-up later: https://github.com/Automattic/dotcom-forge/issues/9938 |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17018084 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @madhusudhand for including a screenshot in the description! This is really helpful for our translators. |
Fixes: https://github.com/Automattic/dotcom-forge/issues/9866
Proposed Changes
/sites/tools/:site
Why are these changes being made?
Testing Instructions
Pre-merge Checklist