Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upsell to Advanced Tools tab #96609

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Add upsell to Advanced Tools tab #96609

merged 6 commits into from
Nov 25, 2024

Conversation

madhusudhand
Copy link
Member

@madhusudhand madhusudhand commented Nov 21, 2024

Fixes: https://github.com/Automattic/dotcom-forge/issues/9866

Proposed Changes

  • Add a new route /sites/tools/:site
  • Re-use the contents of Hosting features in advanced tools
image

Why are these changes being made?

  • Part of untangling hosting menu

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 21, 2024
@matticbot
Copy link
Contributor

matticbot commented Nov 21, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug feature/advanced-tools on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Nov 21, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~87 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-subscriptions         -141 B  (-0.0%)      -48 B  (-0.0%)
entry-login                 -141 B  (-0.0%)      -48 B  (-0.0%)
entry-domains-landing       -141 B  (-0.0%)      -48 B  (-0.0%)
entry-browsehappy           -141 B  (-0.1%)      -48 B  (-0.1%)
entry-stepper               -129 B  (-0.0%)      -87 B  (-0.0%)
entry-main                  -129 B  (-0.0%)      -87 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~8167 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
site-tools             +47592 B  (+2.8%)   +14622 B  (+3.0%)
hosting-features        +1163 B  (+0.1%)     +153 B  (+0.0%)
staging-site             +239 B  (+0.0%)      +33 B  (+0.0%)
sites-dashboard          +239 B  (+0.0%)      +33 B  (+0.0%)
site-settings            +239 B  (+0.0%)      +33 B  (+0.0%)
site-performance         +239 B  (+0.0%)      +33 B  (+0.0%)
site-marketing           +239 B  (+0.0%)      +33 B  (+0.0%)
hosting                  +239 B  (+0.0%)      +33 B  (+0.0%)
github-deployments       +239 B  (+0.0%)      +42 B  (+0.0%)
site-monitoring          +192 B  (+0.0%)     +216 B  (+0.1%)
site-logs                +192 B  (+0.0%)      +33 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

client/sites/components/site-preview-pane/constants.ts Outdated Show resolved Hide resolved
client/sites/tools/controller.tsx Outdated Show resolved Hide resolved
client/sites/tools/controller.tsx Outdated Show resolved Hide resolved
@madhusudhand madhusudhand marked this pull request as ready for review November 21, 2024 11:48
@madhusudhand madhusudhand self-assigned this Nov 21, 2024
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks 👍

@fushar
Copy link
Contributor

fushar commented Nov 25, 2024

Found a small issue, we can follow-up later: https://github.com/Automattic/dotcom-forge/issues/9938

@madhusudhand madhusudhand merged commit 986ff7c into trunk Nov 25, 2024
11 checks passed
@madhusudhand madhusudhand deleted the feature/advanced-tools branch November 25, 2024 11:45
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
@a8ci18n
Copy link

a8ci18n commented Nov 25, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17018084

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @madhusudhand for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants