Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain management: Create add new mailbox subpage #97847

Merged
merged 8 commits into from
Jan 7, 2025

Conversation

bogiii
Copy link
Contributor

@bogiii bogiii commented Dec 30, 2024

Closes #97822
Closes #97826

Proposed Changes

  • Create "Add new mailbox" subpage
  • Adjust the current logic to load a new subpage based on context

Why are these changes being made?

  • Domain Management Revamp project

Testing Instructions

  • Go to /domains/manage?flags=all-domain-management
  • Select a domain with a created mailbox
  • Click on the "Add mailbox" button
  • Check if you stay inside the "all-domain-management" context
  • Pass the purchase step
  • Check if you end up on the mailbox list page
Screenshot 2024-12-30 at 19 02 12 Screenshot 2024-12-30 at 19 02 28

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Dec 30, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~16 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                   +46 B  (+0.0%)      +10 B  (+0.0%)
entry-login                  +46 B  (+0.0%)      +10 B  (+0.0%)
entry-domains-landing        +46 B  (+0.0%)       +9 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~326 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
domains                   +1495 B  (+0.1%)     +319 B  (+0.1%)
email                      +694 B  (+0.1%)     +177 B  (+0.1%)
update-design-flow          +46 B  (+0.0%)       +7 B  (+0.0%)
link-in-bio-tld-flow        +46 B  (+0.0%)       +7 B  (+0.0%)
copy-site-flow              +46 B  (+0.0%)       +7 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~20 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                     +46 B  (+0.0%)       +6 B  (+0.0%)
async-load-signup-steps-domains                                                         +46 B  (+0.0%)       +7 B  (+0.0%)
async-load-purchase-modal-wrapper                                                       +46 B  (+0.0%)       +6 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        +46 B  (+0.0%)       +6 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal                                              +46 B  (+0.0%)       +7 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@bogiii bogiii self-assigned this Dec 30, 2024
@bogiii bogiii requested a review from a team December 30, 2024 18:03
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 30, 2024
@Imran92 Imran92 self-assigned this Dec 31, 2024
@phcp phcp assigned phcp and unassigned Imran92 Jan 3, 2025
@phcp phcp force-pushed the update/domains-management-email-12 branch from 3019788 to 3967d50 Compare January 6, 2025 21:56
@phcp phcp marked this pull request as ready for review January 6, 2025 21:58
@phcp phcp requested a review from a team as a code owner January 6, 2025 21:58
Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I've noticed that if we add a new mailbox and complete the checkout, after redirection, the new mailbox is not immediately visible in the list. If we do a reloading or tab switching, then it becomes visible. You can take care of that either here or create a new issue for it. So approving 👍

@phcp
Copy link
Contributor

phcp commented Jan 7, 2025

However, I've noticed that if we add a new mailbox and complete the checkout, after redirection, the new mailbox is not immediately visible in the list. If we do a reloading or tab switching, then it becomes visible.

Good call @Imran92. There is a new-email param that does that, so I just pushed a fix for that. Thank you!

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phcp phcp merged commit c43256e into trunk Jan 7, 2025
11 checks passed
@phcp phcp deleted the update/domains-management-email-12 branch January 7, 2025 17:34
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 7, 2025
@a8ci18n
Copy link

a8ci18n commented Jan 7, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17094189

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @bogiii for including a screenshot in the description! This is really helpful for our translators.

@bogiii
Copy link
Contributor Author

bogiii commented Jan 9, 2025

@phcp, thanks for wrapping up this PR. 💯

@a8ci18n
Copy link

a8ci18n commented Jan 12, 2025

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create page to add new mailbox "Add mailbox" button not taking users to the new revamped screen
5 participants