Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans Spotlight: Align action button with a flexbox #98195

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Conversation

ddc22
Copy link
Contributor

@ddc22 ddc22 commented Jan 10, 2025

Proposed Changes

  • Move spotlight plan button to flex container instead of using absolute placement

Why are these changes being made?

  • Bug reports raised above and better display of elements
image

Testing Instructions

  • Go to the plans page and make sure the spotlight plan works well on Free plan and Business plan in resolutions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 10, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~24 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
update-design-flow          +91 B  (+0.0%)      +24 B  (+0.0%)
plugins                     +91 B  (+0.0%)      +24 B  (+0.0%)
plans                       +91 B  (+0.0%)      +24 B  (+0.0%)
link-in-bio-tld-flow        +91 B  (+0.0%)      +24 B  (+0.0%)
jetpack-app                 +91 B  (+0.0%)      +24 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~24 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected        +91 B  (+0.0%)      +24 B  (+0.0%)
async-load-signup-steps-plans                          +91 B  (+0.0%)      +24 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ddc22 ddc22 force-pushed the fix/center-plan-button branch from df087d6 to 00452d6 Compare January 10, 2025 19:15
@ddc22 ddc22 force-pushed the fix/center-plan-button branch from 00452d6 to b1310e6 Compare January 10, 2025 19:17
@ddc22 ddc22 self-assigned this Jan 10, 2025
@ddc22 ddc22 changed the title Center align button Plans Spotlight: Align button with a flexbox Jan 10, 2025
@ddc22 ddc22 marked this pull request as ready for review January 10, 2025 20:08
@ddc22 ddc22 requested a review from a team as a code owner January 10, 2025 20:08
@ddc22 ddc22 requested a review from southp January 10, 2025 20:08
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
@ddc22 ddc22 changed the title Plans Spotlight: Align button with a flexbox Plans Spotlight: Align actionbutton with a flexbox Jan 12, 2025
@ddc22 ddc22 changed the title Plans Spotlight: Align actionbutton with a flexbox Plans Spotlight: Align action button with a flexbox Jan 12, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/center-plan-button on your sandbox.

@ddc22 ddc22 merged commit 92230fa into trunk Jan 13, 2025
11 checks passed
@ddc22 ddc22 deleted the fix/center-plan-button branch January 13, 2025 15:56
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants