Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains Management Revamp: Show the Add Forward Email subpage in site context #98294

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

phcp
Copy link
Contributor

@phcp phcp commented Jan 13, 2025

Closes #98048

Proposed Changes

  • Show the Add Forward Email subpage in the site context.

Why are these changes being made?

  • This is part of the Domain Management Revamp project: pfuQfP-13x-p2.

Testing Instructions

  • Apply this PR to your local.
  • Go to http://calypso.localhost:3000/sites?flags=calypso/all-domain-management.
  • Click on a site with a domain previously configured and without email configured.
  • Scroll down to the domains table and click on the domain.
  • You should see the domain overview page within the site context.
  • Click on the Emails tab.
  • Scroll down and click to add a Forwarding Email.
  • You should be redirected to the Add Forwarding Email subpage within the site context.
  • Add a forwarding email and click to submit.
  • You should be redirected back to the email tab.
  • Go back to the Add Forwarding Email page.
  • Click to cancel.
  • You should also be redirected to the email tab.
  • Go back to the Add Forwarding Email page.
  • Navigate using the breadcrumb and see the items behave as expected.
  • The navigation should happen within the site context.
  • Perform regression tests on the Add Forwarding Email page in the domain context.
  • Perform regression tests on the Add Forwarding Email page in the old layout.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@phcp phcp requested a review from a team January 13, 2025 20:04
@phcp phcp self-assigned this Jan 13, 2025
@phcp phcp requested a review from a team as a code owner January 13, 2025 20:04
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 13, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/domains-management-add-forward-email on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 13, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~122 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +100 B  (+0.0%)      +65 B  (+0.0%)
entry-login                 +100 B  (+0.0%)      +65 B  (+0.0%)
entry-domains-landing       +100 B  (+0.0%)      +60 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~136 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
hosting                    +466 B  (+0.0%)      +82 B  (+0.0%)
domains                    +275 B  (+0.0%)      +48 B  (+0.0%)
update-design-flow         +100 B  (+0.0%)      +54 B  (+0.0%)
link-in-bio-tld-flow       +100 B  (+0.0%)      +54 B  (+0.0%)
copy-site-flow             +100 B  (+0.0%)      +54 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~169 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                    +100 B  (+0.0%)      +49 B  (+0.0%)
async-load-signup-steps-domains                                                        +100 B  (+0.0%)      +58 B  (+0.0%)
async-load-purchase-modal-wrapper                                                      +100 B  (+0.0%)      +49 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...       +100 B  (+0.0%)      +49 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal                                             +100 B  (+0.0%)      +62 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it with the live link related to this PR and I found two issues.

There is a wrong breadcrumb text, it says "Contact information"
Screenshot 2025-01-14 at 11 58 43

Also, I tried to click on the "Email" breadcrumb item, and nothing happened.

@Imran92
Copy link
Contributor

Imran92 commented Jan 14, 2025

There's an unit test failing alert from CI, we should take care of it before merging

@phcp phcp requested a review from bogiii January 14, 2025 12:09
Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have a problem with the breadcrumbs navigation.

Screen Capture on 2025-01-14 at 13-37-03

@phcp
Copy link
Contributor Author

phcp commented Jan 14, 2025

@bogiii, interesting. I couldn't reproduce this issue here, it navigates correctly using the breadcrumb. There was only a type check issue, which I fixed in the previous commit. Is there a URL for the broken link? If so, could you share it?

@phcp phcp requested a review from bogiii January 14, 2025 16:04
@phcp
Copy link
Contributor Author

phcp commented Jan 14, 2025

@bogiii, it was exactly what you mentioned. The site and domain order were wrong in the path, I just pushed a fix. When you have a chance, could you test it again and let me know if that works?

Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well now. Good job!!!

I have found a CSS issue with breadcrumbs on smaller screens, but we can handle separatelly in the future PR.

Screenshot 2025-01-14 at 18 10 29

@phcp phcp merged commit 7f59272 into trunk Jan 14, 2025
12 checks passed
@phcp phcp deleted the add/domains-management-add-forward-email branch January 14, 2025 18:57
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site-context: show the Add Forward Email sub-page
4 participants