Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release newsletter goal launchpad tasks #99445

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

p-jackson
Copy link
Member

@p-jackson p-jackson commented Feb 7, 2025

Related to #98305

Proposed Changes

This change removes the feature flag for the newsletter goal from the
onboarding flow. The flag is no longer necessary as the feature we are
enabling the feature for all users.

I left the ability to mock feature flags in the goalsToIntent(). Seems
like it could be useful in the future.

Why are these changes being made?

  • The CfT didn't raise anything that was a blocker for the newsletter goal specifically.

Testing Instructions

  • Follow the CfT instructions pdtkmj-3k2-p2 (except the ?flags=onboarding/newsletter-goal query param will now be ignored)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

This change removes the feature flag for the newsletter goal from the
onboarding flow. The flag is no longer necessary as the feature we are
enabling the feature for all users.

I left the ability to mock feature flags in the `goalsToIntent()`. Seems
like it could be useful in the future.
@p-jackson p-jackson self-assigned this Feb 7, 2025
@p-jackson p-jackson requested a review from a team February 7, 2025 02:02
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2025
@p-jackson p-jackson changed the title Remove newsletter goal feature flag Release newsletter goal launchpad tasks Feb 7, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~66 bytes removed 📉 [gzipped])

name             parsed_size           gzip_size
onboarding-flow       -133 B  (-0.1%)      -20 B  (-0.0%)
site-setup-wg          -93 B  (-0.0%)      -46 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@p-jackson p-jackson merged commit 5406049 into trunk Feb 7, 2025
18 checks passed
@p-jackson p-jackson deleted the update/release-newsletter-goal-intent branch February 7, 2025 03:55
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants