Optimize apache_request_headers #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donnchawp
reviewed
Feb 14, 2018
| $remote_mod_time = $_SERVER[ 'HTTP_IF_MODIFIED_SINCE' ]; | ||
| else | ||
| $remote_mod_time = null; | ||
| $headers = apache_request_headers(); |
There was a problem hiding this comment.
Is it safe to presume that apache_request_headers() is available? While it's unlikely, there may be users running very old versions of PHP in unusual setups.
There was a problem hiding this comment.
We have fallback for this function into wp-cache-phase2.php (I've moved it from wp-cache.php to end of wp-cache-phase2.php where is optimized version). In this case, I think that's safe to we presume that this function exists (code is more readable and it's little performance improvement).
stodorovic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apache_request_headers.