fix: amp url serves cached canonical page #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the AMP plugin creates urls with ?amp as GET parameters, but they don't get served in Expert mode caching with "don't serve cached page with get parameters".
This is because the RewriteCond says
%{QUERY_STRING} !.*=.*which translates to "there must be an equals sign in the query string.With ?amp there is no equals sign, so instead of an AMP page, the original page is shown.
This pull requests suggests a proper fix for this condition.
There is an alternative, namely testing for
!.*=.*AND!ampbut since the PHP version checks empty($_GET), there should not be anything in then Query string, hence^$for "blank".