Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPCS fixes and optimization for plugins/domain-mapping.php #615

Merged
merged 3 commits into from
Dec 7, 2018
Merged

PHPCS fixes and optimization for plugins/domain-mapping.php #615

merged 3 commits into from
Dec 7, 2018

Conversation

stodorovic
Copy link

@stodorovic stodorovic commented Sep 17, 2018 •
edited
Loading

Little cleanup for plugins/domain-mapping.php.
Remove all files from directory - props @sjeng

@stodorovic stodorovic mentioned this pull request Sep 17, 2018
Closed
donnchawp
donnchawp requested changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@donnchawp donnchawp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned that changing the two if() checks will make this code harder to read.

plugins/domain-mapping.php Outdated Show resolved Hide resolved
@donnchawp donnchawp merged commit ebb85e3 into Automattic:master Dec 7, 2018
@stodorovic stodorovic deleted the phpcs-plugin-domain-mapping branch December 7, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnchawp donnchawp donnchawp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stodorovic @donnchawp