Removes apache_response_headers and uses only headers_list #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since apache_response_headers does not work properly in PHP 7.x, I've reported the bug 76954. This function is only required for PHP 4.x which is pretty outdated and we can use only headers_list (because WPSC requires PHP>=5.2.4) which returns array of raw headers. I've checked multiple versions of Apache/PHP (until I was researching the bug in PHP) and everything works properly.
I've created php/php-src#3566 which fixes the bug in PHP 7.x. Based on this PR (and my research), I've optimized
wp_cache_get_response_headers(PHPCS fixes and avoid double processing of headers).Short summary:
Fixes: #539, X-Robots-Tag lost when caching