Rename the temp config file correctly and remove wp-admin/.php files #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rename created a file called ".php" in wp-admin before writing to the configuration file. The file is empty but this patch adds a fixer function to delete it and also fixes the rename. Reported: https://wordpress.org/support/topic/php-notice-undefined-variable-13/ https://wordpress.org/support/topic/wp-super-cache-created-a-stray-php/
iandunn
added a commit
to WordPress/wordcamp.org
that referenced
this pull request
Jul 4, 2019
This is a new flag that WPSC adds after it has deleted the file it mistakenly added in `v1.6.4`. Having this in the config prevents `wpsc_fix_164()` from touching the filesystem on every `wp-admin` request. See Automattic/wp-super-cache#673.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rename created a file called ".php" in wp-admin before writing to
the configuration file. The file is empty but this patch adds a fixer
function to delete it and also fixes the rename.
Reported:
https://wordpress.org/support/topic/php-notice-undefined-variable-13/
https://wordpress.org/support/topic/wp-super-cache-created-a-stray-php/