Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Pumpkins & Melons to not be player placed #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

n1ckoates
Copy link
Contributor

With the current default configuration, players can repeatedly place and break a pumpkin (or a melon with silk touch) and get farming XP each time. This fixes that by requiring pumpkins and melons to not be player placed.

I also moved melon to the same category as pumpkin; given that they require the same effort to grow, it makes sense that they give the same XP. Melons and pumpkins don't have growth stages either (their stems do), so fully_grown isn't necessary. It also means less config lines!

As a side note, I noticed the default configuration doesn't actually give XP for glow berries, cactuses, or sugar cane, despite them being in the config because they don't have growth stages. This is something you probably want to address by having a trigger for picking berries and for breaking cactuses/sugar cane (e.g. breaking a 3 high sugar cane at the bottom gives XP for each block).

Thanks!

@n1ckoates n1ckoates requested a review from WillFP as a code owner June 28, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant