Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue impl for other node type execution, support triggering #58

Merged
merged 19 commits into from
Dec 12, 2024
Merged

Continue impl for other node type execution, support triggering #58

merged 19 commits into from
Dec 12, 2024

Conversation

v9n
Copy link
Member

@v9n v9n commented Dec 11, 2024 •
edited
Loading

Fixes #51 #52 #54

Continue adding functionality including:

  • Add graphql runner
  • Add contract read runner
  • Add block trigger (finally)
  • Support manually trigger a task.
  • Set tax completed when expired or reaching max execution

@v9n v9n changed the title Continue impl for other node execution Continue impl for other node type execution Dec 11, 2024
@v9n v9n marked this pull request as draft December 11, 2024 17:41
@v9n v9n changed the title Continue impl for other node type execution Continue impl for other node type execution, support triggering Dec 11, 2024
Base automatically changed from update-list-task-and-execution-endpoint to main December 11, 2024 18:15
@v9n v9n force-pushed the continue-impl-for-other-node-execution branch from 84ef4a1 to cb0d0a2 Compare December 11, 2024 22:04
@v9n v9n force-pushed the continue-impl-for-other-node-execution branch from c2f0019 to 1f92c82 Compare December 12, 2024 00:29
@v9n v9n marked this pull request as ready for review December 12, 2024 01:35
@v9n v9n requested review from imstar15 and chrisli30 December 12, 2024 01:36
chrisli30
chrisli30 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@chrisli30 chrisli30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks straight-forward 👍

v9n added 2 commits December 11, 2024 18:36
@v9n
update error message on auth failure (#60)
003cb3f 
* update error message on auth failure

* update error message
@v9n
Merge pull request #59 from AvaProtocol/update-proto-buf-for-feedback
e8dc6bb 
Update protobuf method for feedback
This was referenced Dec 12, 2024
Closed
Closed
Closed
@v9n v9n merged commit b88c795 into main Dec 12, 2024
4 checks passed
@v9n v9n deleted the continue-impl-for-other-node-execution branch December 12, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisli30 chrisli30 chrisli30 approved these changes

@imstar15 imstar15 Awaiting requested review from imstar15

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nit pick: rename FixedEpochCondition to be more comprehensive
2 participants
@v9n @chrisli30