Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename TriggerMark -> TriggerMetadata #68

Merged
merged 3 commits into from
Dec 12, 2024
Merged

rename TriggerMark -> TriggerMetadata #68

merged 3 commits into from
Dec 12, 2024

Conversation

v9n
Copy link
Member

@v9n v9n commented Dec 12, 2024

Fixed #67 #69

We need to fix this sooner than later before we familiar with the name

@v9n v9n requested a review from chrisli30 December 12, 2024 05:30
Copy link
Member

@chrisli30 chrisli30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@v9n v9n merged commit a3c4ce7 into main Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The TriggerMark variable name does not sound very straight-forward
2 participants