Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase scheduler’s max allowed weight to unblock extrinsics via governance #388

Closed
chrisli30 opened this issue Jul 21, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@chrisli30
Copy link
Member

Description

We recently found that council.setMembers() extrinsic couldn’t successfully due to scheduler’spermenantlyOverweight error during governance referendum execution. This issue started to happen after Turing’s v1.9.0 release mostly due to the introduction of proofSize in Weight struct.

The solution is to change the below constant variable so it’s updated during the next release.
image

Turing’s current calculation:
https://github.com/OAK-Foundation/OAK-blockchain/blob/0ebac6996c25d8d721bc34912adba39d5e595b6d/runtime/turing/src/lib.rs#L747

Shiden’s calculation for reference:
https://github.com/AstarNetwork/Astar/blob/c9afb955bbed7afb7158899737505a8c6cc3a2a2/runtime/shiden/src/lib.rs#L173

I think we can just increase the percentage, currently at 10%, to higher to approximately equate to 2,048,000 proofsize.

Steps to Reproduce

https://polkadot.js.org/apps/#/explorer/query/0xa66312c8b29966a47059aa63dc53cdb1f36b674c9b5183723520fd07be1bd4c7
CleanShot 2023-07-21 at 01 23 44

Expected vs. Actual Behavior

A simiple council.setMembers() call should pass and not encounter scheduler.permenantlyOverweight error.

Environment

The issue was found on Turing Staging.

@chrisli30 chrisli30 added the bug Something isn't working label Jul 21, 2023
@chrisli30 chrisli30 assigned imstar15 and chrisli30 and unassigned imstar15 Jul 21, 2023
chrisli30 added a commit that referenced this issue Jul 26, 2023
…Democracy problem (#389)

* Increase scheduler pallet’s maximumSchedulerWeight to fix Democracy weight limit too low problem

* Update the MaximumSchedulerWeight for Neumann and OAK too
@chrisli30
Copy link
Member Author

The fix has been tested on Staging with v1.9.0.2. We’ll deploy it to Turing next week.

@chrisli30
Copy link
Member Author

1.9.0.2 runtime 294 has been pushed to Turing Network. This issue is solved.

imstar15 added a commit that referenced this issue Sep 13, 2023
…Democracy problem (#422)

* Increase scheduler pallet’s maximumSchedulerWeight to fix Democracy weight limit too low problem

* Update the MaximumSchedulerWeight for Neumann and OAK too

---------

Co-authored-by: chrisli30 <chrisli30@users.noreply.github.com>
imstar15 added a commit that referenced this issue Sep 13, 2023
…Democracy problem (#422)

* Increase scheduler pallet’s maximumSchedulerWeight to fix Democracy weight limit too low problem

* Update the MaximumSchedulerWeight for Neumann and OAK too

---------

Co-authored-by: chrisli30 <chrisli30@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants