added caching to build sqlite3 connection

Avaiga · Nov 15, 2023 · c9387fb · c9387fb
1 parent c583914
commit c9387fb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/taipy/core/_repository/db/_sql_connection.py b/src/taipy/core/_repository/db/_sql_connection.py
@@ -78,5 +78,9 @@ def _build_connection() -> Connection:
     except KeyError:
         raise MissingRequiredProperty("Missing property db_location")
 
-    connection = sqlite3.connect(db_location, check_same_thread=False)
-    return connection
+    return __build_connection(db_location)
+
+
+@lru_cache
+def __build_connection(db_location: str):
+    return sqlite3.connect(db_location, check_same_thread=False)
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -445,7 +445,9 @@ def init_sql_repo(tmp_sqlite):
     Config.configure_core(repository_type="sql", repository_properties={"db_location": tmp_sqlite})
 
     # Clean SQLite database
-    _SQLConnection._connection = None
+    if _SQLConnection._connection:
+        _SQLConnection._connection.close()
+        _SQLConnection._connection = None
     connection = _SQLConnection.init_db()
     connection.execute(str(DropTable(_CycleModel.__table__, if_exists=True).compile(dialect=sqlite.dialect())))
     connection.execute(str(DropTable(_DataNodeModel.__table__, if_exists=True).compile(dialect=sqlite.dialect())))