This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
feature/#734 apply is-consistent to sequence and scenario #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrobinAV
reviewed
Aug 31, 2023
Comment on lines
178
to
180
| if not sequence._is_consistent(): | ||
| # TODO: add test check raise this exception | ||
| raise InvalidSequence(sequence_id) |
There was a problem hiding this comment.
Since the _create method is only used when reading the sequence, we should also use sequence._is_consistent method when adding or changing a scenario sequence.
☂️ Python Cov
Overall Coverage
New FilesNo new covered files... Modified Files
|
jrobinAV
approved these changes
Sep 5, 2023
toan-quach
deleted the
feature/#734-apply-is-consistent-check-in-Sequence-and-Scenario
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#734