Skip to content
This repository has been archived by the owner on Jan 2, 2024. It is now read-only.

feature/#764 added submission entity, manager and repo #822

Merged
merged 22 commits into from
Nov 20, 2023
Merged

feature/#764 added submission entity, manager and repo #822

merged 22 commits into from
Nov 20, 2023

Conversation

toan-quach
Copy link
Member

No description provided.

jrobinAV
jrobinAV reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
It needs to be completed, in particular the unit tests.

src/taipy/core/_orchestrator/_orchestrator.py Outdated Show resolved Hide resolved
src/taipy/core/submission/submission.py Outdated Show resolved Hide resolved
src/taipy/core/submission/submission.py Outdated Show resolved Hide resolved
src/taipy/core/submission/submission.py Show resolved Hide resolved
src/taipy/core/submission/submission.py Outdated Show resolved Hide resolved
src/taipy/core/submission/_submission_converter.py Outdated Show resolved Hide resolved
src/taipy/core/submission/_submission_manager.py Outdated Show resolved Hide resolved
src/taipy/core/submission/submission_status.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited
Loading

☂️ Python Cov

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8671 8215 95% 85% 🟢

New Files

File Coverage Status
src/taipy/core/submission/init.py 100% 🟢
src/taipy/core/submission/_submission_converter.py 100% 🟢
src/taipy/core/submission/_submission_fs_repository.py 100% 🟢
src/taipy/core/submission/_submission_manager.py 100% 🟢
src/taipy/core/submission/_submission_manager_factory.py 90% 🟢
src/taipy/core/submission/_submission_model.py 100% 🟢
src/taipy/core/submission/_submission_sql_repository.py 100% 🟢
src/taipy/core/submission/submission.py 95% 🟢
src/taipy/core/submission/submission_id.py 100% 🟢
src/taipy/core/submission/submission_status.py 100% 🟢
TOTAL 98% 🟢

Modified Files

File Coverage Status
src/taipy/core/_entity/_entity_ids.py 100% 🟢
src/taipy/core/_entity/_reload.py 100% 🟢
src/taipy/core/_manager/_manager.py 99% 🟢
src/taipy/core/_orchestrator/_abstract_orchestrator.py 100% 🟢
src/taipy/core/_orchestrator/_orchestrator.py 98% 🟢
src/taipy/core/_repository/db/_sql_connection.py 96% 🟢
src/taipy/core/_version/_version_sql_repository.py 100% 🟢
src/taipy/core/cycle/_cycle_manager.py 100% 🟢
src/taipy/core/job/_job_manager.py 100% 🟢
src/taipy/core/job/job.py 98% 🟢
src/taipy/core/notification/event.py 100% 🟢
src/taipy/core/scenario/_scenario_manager.py 96% 🟢
src/taipy/core/sequence/_sequence_manager.py 94% 🟢
src/taipy/core/taipy.py 88% 🟢
src/taipy/core/task/_task_manager.py 96% 🟢
TOTAL 98% 🟢

updated for commit: e445355 by action🐍

@trgiangdo trgiangdo self-requested a review November 10, 2023 10:04
jrobinAV
jrobinAV suggested changes Nov 14, 2023
View reviewed changes
tests/core/notification/test_events_published.py Outdated Show resolved Hide resolved
src/taipy/core/job/job.py Outdated Show resolved Hide resolved
tests/core/notification/test_events_published.py Outdated Show resolved Hide resolved
tests/core/notification/test_events_published.py Show resolved Hide resolved
@toan-quach toan-quach requested a review from jrobinAV November 15, 2023 07:57
gmarabout
gmarabout reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@gmarabout gmarabout left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋🏻
I just added some small comments on the code.
Maybe a quick description of the PR would have helped me provide you with a better review :-)

src/taipy/core/submission/submission.py Outdated Show resolved Hide resolved
src/taipy/core/submission/submission.py Outdated Show resolved Hide resolved
src/taipy/core/submission/submission.py Show resolved Hide resolved
src/taipy/core/submission/submission.py Show resolved Hide resolved
src/taipy/core/submission/submission.py Show resolved Hide resolved
jrobinAV
jrobinAV previously approved these changes Nov 16, 2023
View reviewed changes
@jrobinAV jrobinAV self-requested a review November 16, 2023 15:25
@toan-quach toan-quach force-pushed the feature/#764-create-submission-entity branch from 8dc1a0c to e043563 Compare November 17, 2023 03:56
@toan-quach toan-quach requested a review from gmarabout November 17, 2023 09:45
@toan-quach toan-quach merged commit a9c256d into develop Nov 20, 2023
41 of 42 checks passed
@toan-quach toan-quach deleted the feature/#764-create-submission-entity branch November 20, 2023 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrobinAV jrobinAV jrobinAV approved these changes

@trgiangdo trgiangdo Awaiting requested review from trgiangdo

@gmarabout gmarabout Awaiting requested review from gmarabout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toan-quach @gmarabout @jrobinAV @trgiangdo