This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
bug/ fixed import path broke enterprise repo import #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarabout
approved these changes
Nov 22, 2023
|
@gmarabout no worry!! I'll merge it once the tests passed :D |
☂️ Python Cov
Overall Coverage
New FilesNo new covered files... Modified Files
|
trgiangdo
approved these changes
Nov 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The tests in enterprise repo are failing due to unable to import
from src.taipy.core.notification.event import _make_event.https://github.com/Avaiga/taipy-enterprise/actions/runs/6958399104/job/18933316373?pr=267
Change
Due to the structure of our dependencies, relative import is preferred as absolute import doesn't work. This PR provides a simple fix to the issue by replacing absolute import with relative import