Skip to content
This repository has been archived by the owner on Jan 2, 2024. It is now read-only.

Event Creation: Add version and make sure we don't call autoreload attributes #834

Closed
wants to merge 1 commit into from

Conversation

gmarabout
Copy link
Contributor

Goal

  • Make sure all events are created without accessing fields that would "auto reload" the entity (and thus could create performance issues)
  • Add version in metadata of entities

Changed

  • Data_node: add _version
  • Job: Use internal fields to by-pass autoreload
  • Scenario: Use internal fields to by-pass autoreload
  • Submission: small refactoring
  • Cycle: no change, there is no version for it?

@gmarabout gmarabout marked this pull request as ready for review November 29, 2023 13:50
@gmarabout gmarabout requested a review from jrobinAV November 29, 2023 13:50
@gmarabout gmarabout changed the title Add version and make sure we don't call autoreload attributes Event Creation: Add version and make sure we don't call autoreload attributes Nov 29, 2023
Copy link
Member

@toan-quach toan-quach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! but can you quickly explain why we wouldn't want to use auto reload here? Is the consistency of the value already guaranteed?

@gmarabout
Copy link
Contributor Author

looks good to me! but can you quickly explain why we wouldn't want to use auto reload here? Is the consistency of the value already guaranteed?

@toan-quach I actually don't want autoreload to happen! This function must have the least performance penalty possible 🚀

Copy link

☂️ Python Cov

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8721 8261 95% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/taipy/core/data/data_node.py 99% 🟢
src/taipy/core/job/job.py 98% 🟢
src/taipy/core/scenario/scenario.py 94% 🟢
src/taipy/core/submission/submission.py 95% 🟢
TOTAL 96% 🟢

updated for commit: 8b94193 by action🐍

Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be re done in taipy repository !

@gmarabout gmarabout self-assigned this Nov 29, 2023
@gmarabout gmarabout closed this Dec 1, 2023
@jrobinAV jrobinAV deleted the feature/update_events_metadata branch December 1, 2023 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants